Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Preview files not in an open Folder or Workspace #1

Closed
nanangp opened this issue Nov 3, 2023 · 2 comments
Closed

[Feature] Preview files not in an open Folder or Workspace #1

nanangp opened this issue Nov 3, 2023 · 2 comments

Comments

@nanangp
Copy link
Owner

nanangp commented Nov 3, 2023 •
edited
Loading

Waiting for stdout support (wireviz/WireViz#320) to be released (potentially when they get to 0.4.0?)

Edit: nope, this can be resolved by simply using the appropriate localResourceRoot on the webview.
@nanangp nanangp changed the title Preview files not in an open Folder or Workspace [Feature] Preview files not in an open Folder or Workspace Nov 3, 2023
@nanangp nanangp closed this as completed in aa42f4c Nov 6, 2023
@martinrieder
Copy link

martinrieder commented May 13, 2024 •
edited
Loading

Please note that wireviz/WireViz#321 resolves wireviz/WireViz#320, which is now part of the 0.4 release. It may not be necessary to reopen this issue due to #5 WireViz 0.4 changing commandline options and output formats.

@nanangp
Copy link
Owner Author

nanangp commented May 13, 2024

wireviz/WireViz#321 ... which is now part of the 0.4 release

Doesn't look like it has been merged. Had a look the 0.4 commit and couldn't find any of the changes.

Also, this bug turned out to not need stdin/out after all, and was resolved another way.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nanangp @martinrieder