Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Can't update an already opened local file in the cpu emulator #524

Open
1 of 2 tasks
dorianignee opened this issue Dec 4, 2024 · 1 comment
Open
1 of 2 tasks
Labels
bug Something isn't working

Comments

@dorianignee
Copy link
Contributor

Tool

CPU Emulator

Interface

Website (https://nand2tetris.github.io/web-ide)

Contact Details

[email protected]

What happened?

Reproduction steps:

  1. click 📂 on the CPU Emulator page
  2. click "Select local file" and choose some .asm file
    2.1. the file contents are shown in the CPU pane
  3. change the contents of the selected file locally
  4. repeat steps 1-2 with the same file
    4.1. the old file contents remain in the CPU pane

Expected behavior:
The new contents of the selected file should appear in the ROM section

Actual behavior:
The open-file-dialog closes. The "Choose file" dialog of the website remains open. The old code remains in the ROM section of the page.

Operating system:
Windows 11 Version 23H2 (Build 22635.3936)
Google Chrome Version 131.0.6778.109

Additional Comments

No response

Do you want to try to fix this bug?

  • I want to try to add this feature!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@dorianignee dorianignee added the bug Something isn't working label Dec 4, 2024
@CodeQuiver
Copy link

I have had the same issue, though it presents simply as the new upload never completing when I attempt to upload the new version. The modal view as pictured just persists until I click out of it. For reference this is in Edge (which I use in this case because it normally works with the tool without issue). Refreshing the entire page allows me to upload the file successfully, but that also means I have to re-select the test file I am using
bug
.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants