Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Overhaul of online_reps class #4656

Open
wants to merge 8 commits into
base: develop
Choose a base branch
from
Open

Overhaul of online_reps class #4656

wants to merge 8 commits into from

Conversation

pwojcikdev
Copy link
Contributor

This is an overhaul of online_reps class:

  • Run periodic online weight sampling on a dedicated thread, which makes it more robust and easier to debug.
  • Eliminate use of store.online_weight.count () and erasing entries based on their timestamps instead (2 weeks for live, 1 day for beta).
  • Add stats and logging to improve observability.
  • Add asserts to ensure data consistency.
  • Split and rewrite functions, so they are (subjectively) cleaner.
  • Ensure that nano::online_reps::trended () can never return value lower than the limit configured via online_weight_minimum.

gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
Squash merge PR nanocurrency#4656: Overhaul of online_reps class
4ee8a90
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
Squash merge PR nanocurrency#4656: Overhaul of online_reps class
9bcbb1d
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jun 26, 2024
Squash merge PR nanocurrency#4656: Overhaul of online_reps class
22dba8c
@qwahzi qwahzi added this to the V27 milestone Jul 1, 2024
gr0vity-dev pushed a commit to gr0vity-dev/nano-node that referenced this pull request Jul 7, 2024
Squash merge PR nanocurrency#4656: null
ec37e65
clemahieu
clemahieu previously approved these changes Jul 15, 2024
View reviewed changes
@qwahzi qwahzi modified the milestones: V27, V26.0, V28 Jul 23, 2024
@pwojcikdev
Merge branch 'develop' into online-reps-overhaul
5b057bb 
# Conflicts:
#	nano/core_test/node.cpp
#	nano/lib/logging_enums.hpp
#	nano/lib/stats_enums.hpp
#	nano/lib/thread_roles.cpp
#	nano/lib/thread_roles.hpp
#	nano/node/node.cpp
#	nano/node/node.hpp
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemahieu clemahieu clemahieu left review comments

Assignees
No one assigned
Labels
None yet
Projects
Nano Roadmap
Status: In Progress / V28.0
Milestone
V28
Development

Successfully merging this pull request may close these issues.
3 participants
@pwojcikdev @clemahieu @qwahzi