Rename DelayComponent_list and PhaseComponent_list?

[paulray]

I've been working on the PINT docs, specifically the example notebooks, and I think the names of TimingModel.DelayComponent_list and TimingModel.PhaseComponent_list should be changed. They are the only ones that are in CamelCase and I think it doesn't really make sense.
I think we should consider .delay_component_list or just .delay_components.

Thoughts @luojing1211 @scottransom @demorest @aarchiba ? If we make this change, we should do it before v0.7 I think.

[scottransom]

Hi @paulray. Yeah, I think I agree with you. And that does seem to be something that should probably happen before v0.7 (and be consistent with the paper). I think I'd prefer your last suggestion: .delay_components and .phase_components.

[luojing1211]

It is not as trivial as just renaming the list. The name of the list is also used in server other places. For instance, it a component does not belong to any of the current lists (phase, delay, noise), TimingModel will make a new list for it and named str(NewComponentType) + "_list" (see:

PINT/src/pint/models/timing_model.py

Line 493 in 30d916e

setattr(self, comp_type + "_list", new_comp_list)

)

Since the component type is CamelCase, the list ends up like what it looks right now. If we really want to change this, we can add 'delay', 'phase', etc, as a class member to the Component type class.

[paulray]

I suppose this should be closed since we did not do it before v0.7 and there are some valid reasons for the awkward naming.

[luojing1211]

I am working on some fixes to this issue. It will come soon.

[paulray]

Oops, sorry I thought we decided not to change it. That is great. Reopening.

[luojing1211]

It should not be in the 0.7 version milestone. But I realized there would be some roadblock for future development.

[aarchiba]

Closed by #726