Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendoring doesn't work on a fork. #39

Open
rugwirobaker opened this issue Nov 28, 2018 · 5 comments
Open

Vendoring doesn't work on a fork. #39

rugwirobaker opened this issue Nov 28, 2018 · 5 comments

Comments

@rugwirobaker
Copy link
Contributor

When I tried to build a fork of the project in my own CI and my laptop it could not find the packages.
Example:
main.go:46:2: cannot find package "github.com/nanopack/shaman/api" in any of: /home/travis/gopath/src/github.com/rugwirobaker/shaman/vendor/github.com/nanopack/shaman/api (vendor tree) /home/travis/.gimme/versions/go1.9.linux.amd64/src/github.com/nanopack/shaman/api (from $GOROOT)

@rugwirobaker
Copy link
Contributor Author

It maybe a beginner's issue but please help me I think I like this project.

@rugwirobaker
Copy link
Contributor Author

Solved local build with help from this post

@rugwirobaker
Copy link
Contributor Author

etcd clientv3 dependencies don't seem to work well with govendor. I am trying to integrate etcd as a backend but when I try to build after having created a simple etcd client as according to the the etcd README example it fails(more in the referenced issue). I have successfully build after having replaced govendor with dep. How to you recommend I proceed??

ref: etcd-io/etcd#10288 (comment)

@rugwirobaker rugwirobaker reopened this Nov 30, 2018
@tylerflint
Copy link
Contributor

I think moving to dep is a good move. Would you mind creating a PR that switches to dep?

Once that’s merged into master you should be good to continue here.

Thank you! This is excellent work.

@rugwirobaker
Copy link
Contributor Author

rugwirobaker commented Nov 30, 2018

right away chief.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants