Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dmr multi will not create necessary directories #294

Open
Yang990-sys opened this issue Nov 5, 2024 · 13 comments
Open

dmr multi will not create necessary directories #294

Yang990-sys opened this issue Nov 5, 2024 · 13 comments
Labels
bug Something isn't working troubleshooting workflow and data preparation questions

Comments

@Yang990-sys
Copy link

Yang990-sys commented Nov 5, 2024

After following your guidance in #143 , we have made the following attempts:
image

while, all regions failed for the following reason:
image

In order to check for file errors, I gave different sample names to four samples, and the results were normal:
image

Is there any way to solve my problem?

@Yang990-sys
Copy link
Author

my modkit version :
image

@Yang990-sys
Copy link
Author

Yang990-sys commented Nov 5, 2024

I found the problem. The problem is that the output folder must exist, otherwise an error will occur after creating the folder.

@Yang990-sys Yang990-sys reopened this Nov 5, 2024
@ArtRand
Copy link
Contributor

ArtRand commented Nov 6, 2024

Hello @Yang990-sys,

Thanks for finding this. I think modkit dmr should make the folder if it doesn't exist to align it's behavior with the rest of the commands. I'll make sure to add this to the next release.

@ArtRand ArtRand added the bug Something isn't working label Nov 6, 2024
@ArtRand
Copy link
Contributor

ArtRand commented Nov 11, 2024

I'm going to keep this open to track the work. Thanks again for noticing the inconsistency.

@ArtRand ArtRand reopened this Nov 11, 2024
@ArtRand ArtRand changed the title bedMethyl index missing in dmr multi with replicates dmr multi will not create necessary directories Nov 13, 2024
@Yang990-sys
Copy link
Author

The reason I found seems inaccurate because I encountered this error again. Looking forward to software updates

@ArtRand
Copy link
Contributor

ArtRand commented Nov 25, 2024

Hello @Yang990-sys,

Could you attach the log file for the command that is failing to this thread? Also could you run

tabix -l ${sample}

for each of the samples you have and attach that as well?

@ArtRand ArtRand added the troubleshooting workflow and data preparation questions label Nov 25, 2024
@Yang990-sys
Copy link
Author

Because there is no problem running for a single sample, it should not be an issue with the index itself. When there is a duplicate, the first step of the program is to merge the duplicate samples. So I guess it may be because the merged file cannot use the original index?

@ArtRand
Copy link
Contributor

ArtRand commented Dec 4, 2024

Hello @Yang990-sys,

I understand. It would still be helpful for me to debug what's going on if you can provide the logfile dmr_multi.log. Modkit never actually merges the files, it queries the tables for multiple samples and merges the counts. So the data access for each table/index should be the same - that's what's confusing. I'll try and get to the bottom of this problem ASAP.

@Yang990-sys
Copy link
Author

image
out.log

@ArtRand
Copy link
Contributor

ArtRand commented Dec 4, 2024

@Yang990-sys Just to be sure. All of the pileups use the same reference, which in this case is all_transcripts.fa, correct?

@Yang990-sys
Copy link
Author

Yes, we have encountered the same problem in multiple batches of data

@Yang990-sys
Copy link
Author

I wrote a python script for merging bedmethyl files, and I want to know if it's scientific to merge first and then run modkit dmr

@ArtRand
Copy link
Contributor

ArtRand commented Dec 5, 2024

@Yang990-sys would you be willing to share the data that exposes the problem with me? We can do it through email so that it's not publicly accessible. My email is art.rand [at] nanoporetech.com

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working troubleshooting workflow and data preparation questions
Projects
None yet
Development

No branches or pull requests

2 participants