Skip to content
This repository has been archived by the owner on Nov 6, 2024. It is now read-only.

Test failure introduced by #175 #182

Closed
AJFSalomon opened this issue Apr 8, 2024 · 0 comments · Fixed by #183
Closed

Test failure introduced by #175 #182

AJFSalomon opened this issue Apr 8, 2024 · 0 comments · Fixed by #183

Comments

@AJFSalomon
Copy link
Contributor

I updated my own plugin project with the timeout change in test_and_deploy.yml introduced in #175, and it caused the following test failure after git push:

Invalid workflow file: .github/workflows/test_and_deploy.yml#L23
The workflow is not valid. .github/workflows/test_and_deploy.yml (Line: 23, Col: 5): Unexpected value 'timeout'

I was able to replicate the bug twice by creating brand new plugin templates with slightly different parameters.

I fixed the bug in my own project by replacing timeout: 30 with timeout-minutes: 30. I will file a PR for this, but I figured it was good to also file an issue since the cookiecutter test procedure did not catch the problem.

@Czaki Czaki linked a pull request Apr 8, 2024 that will close this issue
@Czaki Czaki closed this as completed in #183 Apr 8, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant