Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

'Depends on' does not work when added later #419

Open
lucyleeow opened this issue May 3, 2024 · 3 comments
Open

'Depends on' does not work when added later #419

lucyleeow opened this issue May 3, 2024 · 3 comments
Labels
DX Developer experience-related tasks. maintenance CI, dependencies, and other maintenance task

Comments

@lucyleeow
Copy link
Collaborator

🐛 Bug

It seems that the 'Depends on' CI check does not work if you edit the OP later and add it, see #416.

Not super important though.

@lucyleeow lucyleeow added the bug Something isn't working label May 3, 2024
@brisvag
Copy link
Contributor

brisvag commented May 3, 2024

Unfortunatelt you have to retrigger it manually (I just did it) for it to work, or push some new commit, otherwise the workflow won't run!

@psobolewskiPhD
Copy link
Member

Could do something like the edit_pr_description:
https://github.com/napari/docs/blob/main/.github/workflows/edit_pr_description.yml

The idea being to also trigger the check when the PR description is edited.

Actually that's what the docs for the action have:

on:
  pull_request_target: 
    types: [opened, edited, closed, reopened]

jobs:
  check_dependencies:
    runs-on: ubuntu-latest
    name: Check Dependencies
    steps:
    - uses: gregsdennis/dependencies-action@main
      with:
        custom-domains: my-custom-domain.io another.domain.com
      env:
        GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}

@melissawm
Copy link
Member

@melissawm melissawm added task maintenance CI, dependencies, and other maintenance and removed bug Something isn't working labels May 3, 2024
@melissawm melissawm added the DX Developer experience-related tasks. label Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Developer experience-related tasks. maintenance CI, dependencies, and other maintenance task
Projects
Development

No branches or pull requests

4 participants