-
-
Notifications
You must be signed in to change notification settings - Fork 185
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enhancement Request - Date Indication in Messaging Section #1314 #1315
Enhancement Request - Date Indication in Messaging Section #1314 #1315
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you Swetha-Baskaran! for creating this pull request and contributing to Dummygram! 💗
The maintainers will review this Pull Request and provide feedback as soon as possible! 😇
We appreciate your patience and contribution, Keep up the great work! 😀
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi there Swetha-Baskaran!, congratulations on your first pull request :)
Hi @Swetha-Baskaran this looks really great, will be reviewing asap, meanwhile can you please fix those minor issues mentioned by solarcloud analysis? (removing unused imports) Thanks |
I've fixed that minor issue, can you please enable "Allow edits by maintainers" so I can update :) |
Also, now we are automatically scrolled to the top of the windows, instead of being scrolled to the bottom. I'm looking into it, can you assist please? |
done |
sure I'll try raise other pr for that issue |
Quality Gate passedThe SonarCloud Quality Gate passed, but some issues were introduced. 1 New issue |
It's related to how we handle scrollTop function. It's conflicting while loading more messages. We can solve this later. I'm merging this now :) |
Thanks for your contribution! This looks really good, I couldn't even think of this :) |
Issue Id: #1314
Screenshots:
Glad to work with Dummygram :)
@narayan954 Pls review my PR. Let me know for further corrections and changes.