tech review for spectra_generator.md

[jkrick]

This notebook needs a tech review. I think it got a quick check by Troy a while back, but can either @bsipocz or @troyraen please do a tech review?

We don't intend to scale the notebook up, so functions do not need to be modified for efficiency.

[troyraen]

When reviewing, see also: #285

[troyraen]

Updated: 13 Dec 2024

Tracking what's done and still to-do from Tech Review Checklist:

• Documentation
  • Done in Format docstrings in spectroscopy functions #356
• Notebook execution, error handling, etc.
  • Bug: All JWST downloads are failing #360
  • Deal with warnings #361
  • Fix Spitzer logic #362
  • Add a target so that DESIBOSS_get_spec returns data: Minor bug fixes for spectra_generator #365
• Efficiency (skipped)
• Cleanup
  • Most items done in Clean up formatting of spectra_generator.md and related .py files #354, Reduce indentation by inverting if conditions #357, and Clean up comments and formatting #359.
  • Code duplication in HST and JWST. (skipped)
  • Figures with color-blindness simulator. Some are ok, some are more difficult (esp. Red-Blind/Protanopia, Green-Blind/Deuteranopia and Monochromacy/Achromatopsia). We'd probably need to use different line styles to improve this. (deferred to Format figures to be more color-blind friendly #364)
  • Commit empty data/ and output/ directories. In code, make sure directories exist before writing to them. (Doing both to cover all bases). Minor bug fixes for spectra_generator #365

[troyraen]

Everything is done here except for work on the JWST function (#360). Those problems seem to be server-side and we are working with MAST to get them sorted out.

[troyraen]

All items from the tech review checklist are done. Issues with the JWST function have been worked out, at least enough so that it returns data and doesn't raise errors or warnings. Note that some of the files that were previously available no longer exist in the MAST archive (see #360 (comment)).

@bsipocz Do you want this issue to stay open until the rendering issues get worked out?

[bsipocz]

No, we can handle the rendering as a separate question and anything content related coming up in it can have its own issue (e.g. the timeout issue, or anything else that comes up)