From 581594927667a0bf5e2cd0031c7cc9237b15a0b9 Mon Sep 17 00:00:00 2001
From: Leo Singer <leo.singer@ligo.org>
Date: Tue, 15 Aug 2023 12:58:43 -0400
Subject: [PATCH] Refactor latest stable schema redirect

* Combine duplicate implementations
* Get default branch name, rather than assuming that it is 'main'
* Simplify error handling
* Rename /docs/schema/latest redirect to /docs/schema/stable
  for consistency with /schema
---
 app/lib/schema-data.ts                        | 19 ++++++++-----------
 ...ma.latest.$.ts => docs.schema.stable.$.ts} |  3 +--
 app/routes/schema.stable.$.ts                 | 13 ++-----------
 3 files changed, 11 insertions(+), 24 deletions(-)
 rename app/routes/{docs.schema.latest.$.ts => docs.schema.stable.$.ts} (66%)

diff --git a/app/lib/schema-data.ts b/app/lib/schema-data.ts
index e59652ff2..d530d6740 100644
--- a/app/lib/schema-data.ts
+++ b/app/lib/schema-data.ts
@@ -155,19 +155,16 @@ export async function getGithubDir(
   ).data as GitContentDataResponse[]
 }
 
+async function getDefaultBranch() {
+  return (await octokit.rest.repos.get(repoData)).data.default_branch
+}
+
 export async function getLatestRelease() {
-  let latestRelease
   try {
-    latestRelease = (await octokit.rest.repos.getLatestRelease(repoData)).data
+    return (await octokit.rest.repos.getLatestRelease(repoData)).data.tag_name
   } catch (error) {
-    if (error instanceof RequestError) {
-      if (error.status != 404) {
-        throw error
-      }
-      latestRelease = { tag_name: 'main' }
-    } else {
-      throw error
-    }
+    if (error instanceof RequestError && error.status === 404)
+      return await getDefaultBranch()
+    throw error
   }
-  return latestRelease
 }
diff --git a/app/routes/docs.schema.latest.$.ts b/app/routes/docs.schema.stable.$.ts
similarity index 66%
rename from app/routes/docs.schema.latest.$.ts
rename to app/routes/docs.schema.stable.$.ts
index 83fc20eef..b27d3a4ca 100644
--- a/app/routes/docs.schema.latest.$.ts
+++ b/app/routes/docs.schema.stable.$.ts
@@ -4,6 +4,5 @@ import { redirect } from '@remix-run/node'
 import { getLatestRelease } from '~/lib/schema-data'
 
 export async function loader({ params: { '*': path } }: DataFunctionArgs) {
-  const latestRelease = await getLatestRelease()
-  return redirect(`/docs/schema/${latestRelease.tag_name}/${path}`)
+  return redirect(`/docs/schema/${await getLatestRelease()}/${path}`)
 }
diff --git a/app/routes/schema.stable.$.ts b/app/routes/schema.stable.$.ts
index 65b9b0546..c904b3c82 100644
--- a/app/routes/schema.stable.$.ts
+++ b/app/routes/schema.stable.$.ts
@@ -5,21 +5,12 @@
  *
  * SPDX-License-Identifier: Apache-2.0
  */
-import { Octokit } from '@octokit/rest'
 import { type DataFunctionArgs, redirect } from '@remix-run/node'
 
-const githubData = {
-  owner: 'nasa-gcn',
-  repo: 'gcn-schema',
-}
-const octokit = new Octokit()
+import { getLatestRelease } from '~/lib/schema-data'
 
 export async function loader({ params: { '*': path } }: DataFunctionArgs) {
-  const latestRelease = (await octokit.rest.repos.getLatestRelease(githubData))
-    .data
-  if (!latestRelease) throw new Response(null, { status: 404 })
-
   return redirect(
-    `https://raw.githubusercontent.com/nasa-gcn/gcn-schema/${latestRelease.tag_name}/${path}`
+    `https://raw.githubusercontent.com/nasa-gcn/gcn-schema/${await getLatestRelease()}/${path}`
   )
 }