From 0dbf7480e4d677dbe59b821e427d0cda8a374a8b Mon Sep 17 00:00:00 2001
From: Leo Singer <leo.singer@ligo.org>
Date: Mon, 28 Aug 2023 14:43:06 -0400
Subject: [PATCH] String style cleanup

---
 app/components/CircularsKeywords.tsx    | 2 +-
 app/components/Footer.tsx               | 8 +++-----
 app/components/Highlight.tsx            | 2 +-
 app/components/NoticeTypeCheckboxes.tsx | 2 +-
 app/routes/circulars/circulars.lib.ts   | 2 +-
 app/routes/notices.tsx                  | 2 +-
 6 files changed, 8 insertions(+), 10 deletions(-)

diff --git a/app/components/CircularsKeywords.tsx b/app/components/CircularsKeywords.tsx
index 500742f38..00fcfaf06 100644
--- a/app/components/CircularsKeywords.tsx
+++ b/app/components/CircularsKeywords.tsx
@@ -26,7 +26,7 @@ export function CircularsKeywords() {
       <h3>Disallowed subject keywords</h3>
       <ul className="grid-row usa-list usa-list--unstyled">
         {emailAutoReplyChecklist.map((keyword) => (
-          <li key={keyword} className={'tablet:grid-col-3'}>
+          <li key={keyword} className="tablet:grid-col-3">
             {keyword}
           </li>
         ))}
diff --git a/app/components/Footer.tsx b/app/components/Footer.tsx
index d130c1b2a..924ce3e59 100644
--- a/app/components/Footer.tsx
+++ b/app/components/Footer.tsx
@@ -63,7 +63,7 @@ export function Footer() {
           <Grid row gap>
             <ContactLink
               to="/contact"
-              icon={<Icon.Help role="presentation" size={4} color={'white'} />}
+              icon={<Icon.Help role="presentation" size={4} color="white" />}
               headline="Questions or comments?"
             >
               Contact GCN directly
@@ -71,7 +71,7 @@ export function Footer() {
             <ContactLink
               to="https://github.com/nasa-gcn/gcn.nasa.gov/issues"
               icon={
-                <Icon.BugReport role="presentation" size={4} color={'white'} />
+                <Icon.BugReport role="presentation" size={4} color="white" />
               }
               headline="Have you found a bug in GCN?"
             >
@@ -79,9 +79,7 @@ export function Footer() {
             </ContactLink>
             <ContactLink
               to="https://github.com/nasa-gcn/gcn.nasa.gov"
-              icon={
-                <Icon.Github role="presentation" size={4} color={'white'} />
-              }
+              icon={<Icon.Github role="presentation" size={4} color="white" />}
               headline="Want to contribute code to GCN?"
             >
               Get involved on GitHub
diff --git a/app/components/Highlight.tsx b/app/components/Highlight.tsx
index c597b8d33..527b1e7df 100644
--- a/app/components/Highlight.tsx
+++ b/app/components/Highlight.tsx
@@ -34,7 +34,7 @@ export function Highlight({
         {filename && (
           <Tooltip
             position="top"
-            label={'Download ' + filename}
+            label={`Download ${filename}`}
             className="margin-top-1 margin-right-1 usa-button--unstyled"
           >
             <a download={filename} href={`data:,${encodeURIComponent(code)}`}>
diff --git a/app/components/NoticeTypeCheckboxes.tsx b/app/components/NoticeTypeCheckboxes.tsx
index 1cc1a2623..b7b555a89 100644
--- a/app/components/NoticeTypeCheckboxes.tsx
+++ b/app/components/NoticeTypeCheckboxes.tsx
@@ -239,7 +239,7 @@ export function NoticeTypeCheckboxes({
           link:
             selectedFormat !== 'json'
               ? NoticeTypeLinks[mission]
-                ? '/missions/' + NoticeTypeLinks[mission]
+                ? `/missions/${NoticeTypeLinks[mission]}`
                 : undefined
               : JsonNoticeTypeLinks[mission],
           nodes: noticeTypes.map((noticeType) => ({
diff --git a/app/routes/circulars/circulars.lib.ts b/app/routes/circulars/circulars.lib.ts
index ac21f15b8..cd0c938e2 100644
--- a/app/routes/circulars/circulars.lib.ts
+++ b/app/routes/circulars/circulars.lib.ts
@@ -197,7 +197,7 @@ export function formatAuthor({
 
 export function parseEventFromSubject(value: string) {
   for (const [regexp, normalize] of subjectMatchers) {
-    const startsWithMatch = RegExp('^' + regexp.source).exec(value)
+    const startsWithMatch = RegExp(`^${regexp.source}`).exec(value)
     if (startsWithMatch) return normalize(startsWithMatch)
   }
   for (const [regexp, normalize] of subjectMatchers) {
diff --git a/app/routes/notices.tsx b/app/routes/notices.tsx
index a32f68368..09c254846 100644
--- a/app/routes/notices.tsx
+++ b/app/routes/notices.tsx
@@ -78,7 +78,7 @@ function renderTag({
           <Icon.Close
             role="presentation"
             className="margin-left-1 text-bottom"
-            color={'white'}
+            color="white"
           />
         </Button>
       </span>