Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Standardize .vscode settings #2596

Closed
1 task
tylerbarna opened this issue Sep 25, 2024 · 4 comments
Closed
1 task

Standardize .vscode settings #2596

tylerbarna opened this issue Sep 25, 2024 · 4 comments
Labels
enhancement New feature or request

Comments

@tylerbarna
Copy link
Member

Description

Either add .vscode to .gitignore or version it so all developers use similar/the same settings, such as formatting on save

Acceptance criteria

  • .vscode file settings are versioned and standardized
@tylerbarna tylerbarna added the enhancement New feature or request label Sep 25, 2024
@tylerbarna
Copy link
Member Author

As suggested by @dakota002

@lpsinger
Copy link
Member

We have https://github.com/nasa-gcn/gcn.nasa.gov/blob/main/.vscode/settings.json under version control. What else do we need to do to close this?

@dakota002
Copy link
Contributor

@tylerbarna Do you remember which settings were conflicting in your local?

@lpsinger
Copy link
Member

lpsinger commented Dec 4, 2024

Closing this. Please reopen if there are specific settings that should be under version control but are not.

@lpsinger lpsinger closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@lpsinger @dakota002 @tylerbarna