Fix #442, xact priority sorted incorrectly #447
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Pulled in fix from @ctolbert555
Marked as draft because I still need to test the update against the open source
Fixed priority sort functionality
Previously, if the priority to be inserted was the lowest number (highest prio) it would have no matches and be inserted into the back of the queue, which is incorrect, as the sort is meant to sort from lowest number to highest. Now, if it is the lowest number it will be inserted into the front of the queue.
Fixes #442
Testing performed
TBD
Expected behavior changes
TBD
System(s) tested on
TBD
Contributor Info - All information REQUIRED for consideration of pull request
Dan Knutsen
NASA Goddard