From 030d54c9a467aa0421afe771d258cb6072a236d7 Mon Sep 17 00:00:00 2001
From: M Starch <LeStarch@googlemail.com>
Date: Tue, 24 Oct 2023 14:10:04 -0700
Subject: [PATCH 1/6] Fixes nasa/fprim#2312 by correcting scalar validation
 (#147)

---
 .../addons/commanding/argument-templates.js       |  2 +-
 .../flask/static/addons/commanding/arguments.js   | 15 ++++++++++++---
 2 files changed, 13 insertions(+), 4 deletions(-)

diff --git a/src/fprime_gds/flask/static/addons/commanding/argument-templates.js b/src/fprime_gds/flask/static/addons/commanding/argument-templates.js
index 3e1a9de1..c5423d57 100644
--- a/src/fprime_gds/flask/static/addons/commanding/argument-templates.js
+++ b/src/fprime_gds/flask/static/addons/commanding/argument-templates.js
@@ -70,7 +70,7 @@ export let command_array_argument_template = `
  * enumerations are handled here as they represent a single scalar input.
  */
 export let command_scalar_argument_template = `
-<div style="display: contents;">
+<div style="display: contents;" class="fprime-scalar-argument">
     <div class="form-group col-md-6">
         <label :for="argument.name" class="control-label font-weight-bold">
             {{ argument.name + ((argument.description != null) ? ": " + argument.description : "") }}
diff --git a/src/fprime_gds/flask/static/addons/commanding/arguments.js b/src/fprime_gds/flask/static/addons/commanding/arguments.js
index 1700fa3c..7dc71f03 100644
--- a/src/fprime_gds/flask/static/addons/commanding/arguments.js
+++ b/src/fprime_gds/flask/static/addons/commanding/arguments.js
@@ -204,13 +204,22 @@ let base_argument_component_properties = {
             validateArgument(recurse_down) {
                 recurse_down = !!(recurse_down); // Force recurse_down to be defined as a boolean
                 let valid = validate_input(this.argument);
-                // HTML element validation
+                // Each scalar argument needs to set custom validity on the HTML input that it owns. However, non-scalar
+                // inputs skip this step less the first scalar child's input box be poisoned with incorrect validity due
+                // to the unbounded recursive nature of getElementsByClassName used to find a fprime-input children.
+                let is_scalar = [...document.getElementsByClassName("fprime-scalar-argument")]
+                    .filter((scalar) => scalar === this.$el || scalar.contains(this.$el)).length > 0;
+
+                // Now grab the singular the nearest input and report validity if and only if this is a scalar. Non-
+                // scalar values are compositions of scalar children and thus validity will be set when the scalar
+                // itself is validated.
                 let input_element = this.$el.getElementsByClassName("fprime-input")[0] || this.$el;
-                if (input_element.setCustomValidity && input_element.reportValidity) {
+                if (is_scalar && input_element.setCustomValidity && input_element.reportValidity) {
                     input_element.setCustomValidity(this.argument.error);
                     input_element.reportValidity();
                 }
-                // Downward recursion uses children
+                // Validation can happen recursively down through the children, or up through the parent in order to
+                // laterally validate complex arguments when a single input scalar filed is adjusted.
                 let recursive_listing = (recurse_down) ? this.$children.slice().reverse() : [this.$parent];
                 let valid_recursion = (recursive_listing || []).reduce(
                     (accumulator, next_element) => {

From 7c018ce9cb320a436670de4939790f9a11dd068a Mon Sep 17 00:00:00 2001
From: M Starch <LeStarch@googlemail.com>
Date: Tue, 24 Oct 2023 14:10:16 -0700
Subject: [PATCH 2/6] Preventing a launch of Flask when -g none is specified.
 Fixes #2337 (#149)

---
 src/fprime_gds/executables/run_deployment.py | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

diff --git a/src/fprime_gds/executables/run_deployment.py b/src/fprime_gds/executables/run_deployment.py
index cde99133..0b9b9a83 100644
--- a/src/fprime_gds/executables/run_deployment.py
+++ b/src/fprime_gds/executables/run_deployment.py
@@ -112,10 +112,9 @@ def launch_html(parsed_args):
         str(parsed_args.gui_port),
     ]
     ret = launch_process(gse_args, name="HTML GUI", env=flask_env, launch_time=2)
-    if parsed_args.gui == "html":
-        webbrowser.open(
-            f"http://{str(parsed_args.gui_addr)}:{str(parsed_args.gui_port)}/", new=0, autoraise=True
-        )
+    webbrowser.open(
+        f"http://{str(parsed_args.gui_addr)}:{str(parsed_args.gui_port)}/", new=0, autoraise=True
+    )
     return ret
 
 
@@ -172,7 +171,8 @@ def main():
             print("[WARNING] App cannot be auto-launched without IP adapter")
 
     # Launch the desired GUI package
-    launchers.append(launch_html)
+    if parsed_args.gui == "html":
+        launchers.append(launch_html)
 
     # Launch launchers and wait for the last app to finish
     try:

From c9ac3152db2f12bd98ea77cdb82c8e2184b4c85a Mon Sep 17 00:00:00 2001
From: Simone Morettini <morettinisimo96@gmail.com>
Date: Wed, 25 Oct 2023 01:42:32 +0200
Subject: [PATCH 3/6] Added incremental id in history items (#142)

* Added incremental id in history items

* Switches to basic counter for incremental_id

---------

Co-authored-by: M Starch <LeStarch@googlemail.com>
---
 src/fprime_gds/flask/static/js/datastore.js         | 4 +++-
 src/fprime_gds/flask/static/js/vue-support/event.js | 2 +-
 2 files changed, 4 insertions(+), 2 deletions(-)

diff --git a/src/fprime_gds/flask/static/js/datastore.js b/src/fprime_gds/flask/static/js/datastore.js
index ee99cc16..892f128f 100644
--- a/src/fprime_gds/flask/static/js/datastore.js
+++ b/src/fprime_gds/flask/static/js/datastore.js
@@ -28,6 +28,7 @@ class HistoryHelper {
         this.active_key = active_key;
         this.consumers = [];
         this.active_timeout = null;
+        this.counter = 0;
     }
 
     /**
@@ -58,7 +59,8 @@ class HistoryHelper {
         // Break our when no new items returned
         if (new_items.length === 0) { return; }
         new_items.filter((item) => item.time).forEach((item) => {
-            item.datetime = timeToDate(item.time)
+            item.datetime = timeToDate(item.time);
+            item.incremental_id = this.counter++;
         });
         this.consumers.forEach((consumer) => {
             try {
diff --git a/src/fprime_gds/flask/static/js/vue-support/event.js b/src/fprime_gds/flask/static/js/vue-support/event.js
index befed103..441ae9b4 100644
--- a/src/fprime_gds/flask/static/js/vue-support/event.js
+++ b/src/fprime_gds/flask/static/js/vue-support/event.js
@@ -109,7 +109,7 @@ Vue.component("event-list", {
          * @return {string} unique key
          */
         keyify(item) {
-            return "evt-" + item.id + "-" + item.time.seconds + "-"+ item.time.microseconds;
+            return "evt-" + item.id + "-" + item.time.seconds + "-"+ item.time.microseconds + "-" + item.incremental_id;
         },
         /**
          * A function to clear events out of the data store. This is to reset the events entirely.

From b662e64982e172f3d08b5717b303346738982f59 Mon Sep 17 00:00:00 2001
From: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com>
Date: Wed, 15 Nov 2023 15:17:13 -0800
Subject: [PATCH 4/6] Handle PermissionErrors on downlink (#150)

* Handle PermissionErrors on downlink

* spelling and formatting

* Raise PermissionError instead of warning
---
 .github/actions/spelling/expect.txt       |  1 +
 src/fprime_gds/common/files/downlinker.py | 25 +++++++++++++++++------
 src/fprime_gds/common/files/helpers.py    |  1 +
 src/fprime_gds/common/pipeline/files.py   |  9 +++++++-
 4 files changed, 29 insertions(+), 7 deletions(-)

diff --git a/.github/actions/spelling/expect.txt b/.github/actions/spelling/expect.txt
index d9fe23d0..14e4982f 100644
--- a/.github/actions/spelling/expect.txt
+++ b/.github/actions/spelling/expect.txt
@@ -572,6 +572,7 @@ Smath
 SNDHWM
 socketserver
 sorttable
+spam
 sphinxcontrib
 splitext
 squashify
diff --git a/src/fprime_gds/common/files/downlinker.py b/src/fprime_gds/common/files/downlinker.py
index 452114a0..45beae47 100644
--- a/src/fprime_gds/common/files/downlinker.py
+++ b/src/fprime_gds/common/files/downlinker.py
@@ -52,7 +52,6 @@ def __init__(self, directory, timeout=20.0, log_dir=None):
         self.sequence = 0  # Keeps track of what the current sequence ID should be
         self.timer = fprime_gds.common.files.helpers.Timeout()
         self.timer.setup(self.timeout, timeout)
-        os.makedirs(self.__directory, exist_ok=True)
 
     def data_callback(self, data, sender=None):
         """
@@ -96,7 +95,15 @@ def handle_start(self, data):
             size,
             self.__log_dir,
         )
-        self.active.open(TransmitFileState.WRITE)
+        try:
+            self.active.open(TransmitFileState.WRITE)
+        except PermissionError as exc:
+            self.state = FileStates.ERROR
+            LOGGER.warning(
+                "Unable to open file for writing. Discarding subsequent downlink packets. "
+                + str(exc)
+            )
+            return
         LOGGER.addHandler(self.active.log_handler)
         message = "Received START packet with metadata:\n"
         message += "\tSize: %d\n"
@@ -116,7 +123,10 @@ def handle_data(self, data):
         # Initialize all relevant DATA packet attributes into variables from file_data
         offset = data.offset
         if self.state != FileStates.RUNNING:
-            LOGGER.warning("Received unexpected data packet for offset: %d", offset)
+            # ERROR state means GDS is not ready to receive data packets (permission error)
+            # No need to log this, as it is already logged in handle_start and would only spam logs
+            if self.state != FileStates.ERROR:
+                LOGGER.warning("Received unexpected data packet for offset: %d", offset)
         else:
             if data.seqID != self.sequence:
                 LOGGER.warning(
@@ -156,9 +166,10 @@ def handle_end(self, data):
         """
         # Initialize all relevant END packet attributes into variables from file_data
         # hashValue attribute is not relevant right now, but might be in the future
-        if self.state != FileStates.RUNNING:
-            LOGGER.warning("Received unexpected END packet")
-        else:
+        if self.state == FileStates.ERROR:
+            LOGGER.info("Received END packet for discarded downlink")
+            self.finish()
+        elif self.state == FileStates.RUNNING:
             if data.seqID != self.sequence:
                 LOGGER.warning(
                     "End packet has unexpected sequence id. Expected: %d got %d",
@@ -167,6 +178,8 @@ def handle_end(self, data):
                 )
             LOGGER.info("Received END packet, finishing downlink")
             self.finish()
+        else:
+            LOGGER.warning("Received unexpected END packet")
 
     def timeout(self):
         """Timeout the current downlink"""
diff --git a/src/fprime_gds/common/files/helpers.py b/src/fprime_gds/common/files/helpers.py
index ee983615..1b588fc2 100644
--- a/src/fprime_gds/common/files/helpers.py
+++ b/src/fprime_gds/common/files/helpers.py
@@ -77,6 +77,7 @@ class FileStates(enum.Enum):
     RUNNING = 1
     CANCELED = 2
     END_WAIT = 3  # Waiting for the handshake for CANCEL or END packet
+    ERROR = 4
 
 
 class CFDPChecksum:
diff --git a/src/fprime_gds/common/pipeline/files.py b/src/fprime_gds/common/pipeline/files.py
index 43542192..f88b475c 100644
--- a/src/fprime_gds/common/pipeline/files.py
+++ b/src/fprime_gds/common/pipeline/files.py
@@ -7,6 +7,7 @@
 
 @author mstarch
 """
+import os
 import fprime_gds.common.files.downlinker
 import fprime_gds.common.files.uplinker
 
@@ -27,7 +28,8 @@ def setup_file_handling(
         self, down_store, file_encoder, file_decoder, distributor, log_dir
     ):
         """
-        Sets up the file handling (uplink and downlink) from a pair of encoders and decoders
+        Sets up the file handling (uplink and downlink) from a pair of encoders and decoders.
+        Raises a PermissionError if the down_store is not writable.
 
         :param down_store: downlink storage directory
         :param file_encoder: file encoder for uplink
@@ -41,6 +43,11 @@ def setup_file_handling(
         )
         file_decoder.register(self.__downlinker)
         distributor.register("FW_PACKET_HAND", self.__uplinker)
+        if not os.access(down_store, os.W_OK):
+            raise PermissionError(
+                f"{down_store} is not writable. Downlinker not be able to save files. "
+                "Fix permissions or change storage directory with --file-storage-directory."
+            )
 
     @property
     def uplinker(self):

From 54532c8ea8255687bc0df4c265adeeedbd041d47 Mon Sep 17 00:00:00 2001
From: M Starch <LeStarch@googlemail.com>
Date: Mon, 27 Nov 2023 10:17:34 -0800
Subject: [PATCH 5/6] Output unframed (garbage) data to file (#151)

* Allowing output of unframed data

* black formatting

* Calling out error in log pane as error box
---
 .../common/communication/framing.py           | 31 +++++---
 src/fprime_gds/common/communication/ground.py |  2 +-
 src/fprime_gds/common/communication/updown.py | 31 ++++++--
 src/fprime_gds/common/logger/__init__.py      | 13 ++-
 src/fprime_gds/executables/cli.py             | 26 ++++--
 src/fprime_gds/executables/comm.py            | 79 +++++++++++++------
 src/fprime_gds/flask/static/js/datastore.js   | 13 ++-
 .../flask/static/js/vue-support/log.js        | 34 +++++---
 8 files changed, 160 insertions(+), 69 deletions(-)

diff --git a/src/fprime_gds/common/communication/framing.py b/src/fprime_gds/common/communication/framing.py
index 7f9c0c8d..71dea6a6 100644
--- a/src/fprime_gds/common/communication/framing.py
+++ b/src/fprime_gds/common/communication/framing.py
@@ -40,13 +40,13 @@ def deframe(self, data, no_copy=False):
         """
         Deframes the incoming data from the specified format. Produces exactly one packet, and leftover bytes. Users
         wanting all packets to be deframed should call "deframe_all". If no full packet is available, this method
-        returns None. Expects incoming raw bytes to deframe, and returns a deframed packet or None, and the leftover
-        bytes that were unused. Will search and discard data up until a start token is found. Note: data will be
-        consumed up to the first start token found.
+        returns None. Expects incoming raw bytes to deframe, and returns a deframed packet or None, the leftover
+        bytes that were unused, and any bytes discarded from the existing data stream. Will search and discard data up
+        until a start token is found. Note: data will be consumed up to the first start token found.
 
         :param data: framed data bytes
         :param no_copy: (optional) will prevent extra copy if True, but "data" input will be destroyed.
-        :return: (packet as array of bytes or None, leftover bytes)
+        :return: (packet as array of bytes or None, leftover bytes, any discarded data)
         """
 
     def deframe_all(self, data, no_copy):
@@ -56,16 +56,18 @@ def deframe_all(self, data, no_copy):
 
         :param data: framed data bytes
         :param no_copy: (optional) will prevent extra copy if True, but "data" input will be destroyed.
-        :return:
+        :return: list of packets, remaining data, discarded/unframed/garbage data
         """
         packets = []
         if not no_copy:
             data = copy.copy(data)
+        discarded_aggregate = b""
         while True:
             # Deframe and return only on None
-            (packet, data) = self.deframe(data, no_copy=True)
+            (packet, data, discarded) = self.deframe(data, no_copy=True)
+            discarded_aggregate += discarded
             if packet is None:
-                return packets, data
+                return packets, data, discarded_aggregate
             packets.append(packet)
 
 
@@ -147,6 +149,7 @@ def deframe(self, data, no_copy=False):
         :param no_copy: (optional) will prevent extra copy if True, but "data" input will be destroyed.
         :return: (packet as array of bytes or None, leftover bytes)
         """
+        discarded = b""
         if not no_copy:
             data = copy.copy(data)
         # Continue until there is not enough data for the header, or until a packet is found (return)
@@ -163,6 +166,7 @@ def deframe(self, data, no_copy=False):
                 start != FpFramerDeframer.START_TOKEN
                 or data_size >= FpFramerDeframer.MAXIMUM_DATA_SIZE
             ):
+                discarded += data[0:1]
                 data = data[1:]
                 continue
             # If the pool is large enough to read the whole frame, then read it
@@ -175,17 +179,18 @@ def deframe(self, data, no_copy=False):
                     data[: data_size + FpFramerDeframer.HEADER_SIZE]
                 ):
                     data = data[total_size:]
-                    return deframed, data
+                    return deframed, data, discarded
                 print(
                     "[WARNING] Checksum validation failed. Have you correctly set '--comm-checksum-type'",
                     file=sys.stderr,
                 )
                 # Bad checksum, rotate 1 and keep looking for non-garbage
+                discarded += data[0:1]
                 data = data[1:]
                 continue
             # Case of not enough data for a full packet, return hoping for more later
-            return None, data
-        return None, data
+            return None, data, discarded
+        return None, data, discarded
 
 
 class TcpServerFramerDeframer(FramerDeframer):
@@ -237,11 +242,11 @@ def deframe(self, data, no_copy=False):
             data = data[1:]
         # Break out of data when not enough
         if len(data) < 8:
-            return None, data
+            return None, data, b""
         # Read the length and break if not enough data
         (data_len,) = struct.unpack_from(">I", data, 4)
         if len(data) < data_len + 8:
-            return None, data
+            return None, data, b""
         packet = data[8 : data_len + 8]
         data = data[data_len + 8 :]
-        return packet, data
+        return packet, data, b""
diff --git a/src/fprime_gds/common/communication/ground.py b/src/fprime_gds/common/communication/ground.py
index d3f32ba8..2eb05d73 100644
--- a/src/fprime_gds/common/communication/ground.py
+++ b/src/fprime_gds/common/communication/ground.py
@@ -91,7 +91,7 @@ def receive_all(self):
         :return: list deframed packets
         """
         self.data += self.tcp.read()
-        (frames, self.data) = self.deframer.deframe_all(self.data, no_copy=True)
+        (frames, self.data, _) = self.deframer.deframe_all(self.data, no_copy=True)
         return frames
 
     def send_all(self, frames):
diff --git a/src/fprime_gds/common/communication/updown.py b/src/fprime_gds/common/communication/updown.py
index b52145b4..81211e4f 100644
--- a/src/fprime_gds/common/communication/updown.py
+++ b/src/fprime_gds/common/communication/updown.py
@@ -36,16 +36,23 @@ class Downlinker:
     """
 
     def __init__(
-        self, adapter: BaseAdapter, ground: GroundHandler, deframer: FramerDeframer
+        self,
+        adapter: BaseAdapter,
+        ground: GroundHandler,
+        deframer: FramerDeframer,
+        discarded=None,
     ):
         """Initialize the downlinker
 
-        Constructs a new downlinker object used to run the downlink and deframing operation.
+        Constructs a new downlinker object used to run the downlink and deframing operation. This downlinker will log
+        discarded (unframed) data when discarded is a writable data object. When discarded is None the discarded data is
+        dropped.
 
         Args:
             adapter: adapter used to read raw data from the hardware connection
             ground: handles the ground side connection
             deframer: deframer used to deframe data from the communication format
+            discarded: file to write discarded data to. None to drop the data.
         """
         self.running = True
         self.th_ground = None
@@ -54,13 +61,18 @@ def __init__(
         self.ground = ground
         self.deframer = deframer
         self.outgoing = Queue()
+        self.discarded = discarded
 
     def start(self):
         """Starts the downlink pipeline"""
-        self.th_ground = threading.Thread(target=self.sending, name="DownlinkTTSGroundThread")
+        self.th_ground = threading.Thread(
+            target=self.sending, name="DownlinkTTSGroundThread"
+        )
         self.th_ground.daemon = True
         self.th_ground.start()
-        self.th_data = threading.Thread(target=self.deframing, name="DownLinkDeframingThread")
+        self.th_data = threading.Thread(
+            target=self.deframing, name="DownLinkDeframingThread"
+        )
         self.th_data.daemon = True
         self.th_data.start()
 
@@ -74,12 +86,20 @@ def deframing(self):
         while self.running:
             # Blocks until data is available, but may still return b"" if timeout
             pool += self.adapter.read()
-            frames, pool = self.deframer.deframe_all(pool, no_copy=True)
+            frames, pool, discarded_data = self.deframer.deframe_all(pool, no_copy=True)
             try:
                 for frame in frames:
                     self.outgoing.put_nowait(frame)
             except Full:
                 DW_LOGGER.warning("GDS ground queue full, dropping frame")
+            try:
+                if self.discarded is not None:
+                    self.discarded.write(discarded_data)
+                    self.discarded.flush()
+            # Failure to write discarded data should never stop the GDS. Log it and move on.
+            except Exception as exc:
+                DW_LOGGER.warning("Cannot write discarded data %s", exc)
+                self.discarded = None  # Give up on logging further data
 
     def sending(self):
         """Outgoing stage of downlink
@@ -107,6 +127,7 @@ def join(self):
         for thread in [self.th_data, self.th_ground]:
             if thread is not None:
                 thread.join()
+        self.discarded = None
 
     def add_loopback_frame(self, frame):
         """Adds a frame to loopback to ground
diff --git a/src/fprime_gds/common/logger/__init__.py b/src/fprime_gds/common/logger/__init__.py
index f54d2850..e02e36ce 100644
--- a/src/fprime_gds/common/logger/__init__.py
+++ b/src/fprime_gds/common/logger/__init__.py
@@ -10,6 +10,8 @@
 import os
 import sys
 
+INITIALIZED = False
+
 
 def configure_py_log(directory=None, filename=sys.argv[0], mirror_to_stdout=False):
     """
@@ -21,7 +23,14 @@ def configure_py_log(directory=None, filename=sys.argv[0], mirror_to_stdout=Fals
     :param mode: of file to write
     :param mirror_to_stdout: mirror the log output to standard our
     """
-    handlers = [logging.StreamHandler(sys.stdout)] if directory is None or mirror_to_stdout else []
+    global INITIALIZED
+    if INITIALIZED:
+        return
+    handlers = (
+        [logging.StreamHandler(sys.stdout)]
+        if directory is None or mirror_to_stdout
+        else []
+    )
     if directory is not None:
         log_file = os.path.join(directory, os.path.basename(filename))
         log_file = log_file if log_file.endswith(".log") else f"{log_file}.log"
@@ -33,4 +42,4 @@ def configure_py_log(directory=None, filename=sys.argv[0], mirror_to_stdout=Fals
         logging.getLogger().addHandler(handler)
     logging.getLogger().setLevel(logging.INFO)
     logging.info("Logging system initialized!")
-
+    INITIALIZED = True
diff --git a/src/fprime_gds/executables/cli.py b/src/fprime_gds/executables/cli.py
index 171a2d94..3e9d78f0 100644
--- a/src/fprime_gds/executables/cli.py
+++ b/src/fprime_gds/executables/cli.py
@@ -226,12 +226,16 @@ def handle_arguments(self, args, **kwargs):
         if likely_deployment.exists():
             args.deployment = likely_deployment
             return args
-        child_directories = [child for child in detected_toolchain.iterdir() if child.is_dir()]
+        child_directories = [
+            child for child in detected_toolchain.iterdir() if child.is_dir()
+        ]
         if not child_directories:
             msg = f"No deployments found in {detected_toolchain}. Specify deployment with: --deployment"
             raise Exception(msg)
         # Works for the old structure where the bin, lib, and dict directories live immediately under the platform
-        elif len(child_directories) == 3 and set([path.name for path in child_directories]) == {"bin", "lib", "dict"}:
+        elif len(child_directories) == 3 and set(
+            [path.name for path in child_directories]
+        ) == {"bin", "lib", "dict"}:
             args.deployment = detected_toolchain
             return args
         elif len(child_directories) > 1:
@@ -310,8 +314,7 @@ def get_arguments(self) -> Dict[Tuple[str, ...], Dict[str, Any]]:
                 "action": "store",
                 "type": str,
                 "help": "Adapter for communicating to flight deployment. [default: %(default)s]",
-                "choices": ["none"]
-                + list(adapter_definition_dictionaries),
+                "choices": ["none"] + list(adapter_definition_dictionaries),
                 "default": "ip",
             },
             ("--comm-checksum-type",): {
@@ -326,6 +329,15 @@ def get_arguments(self) -> Dict[Tuple[str, ...], Dict[str, Any]]:
                 ],
                 "default": fprime_gds.common.communication.checksum.CHECKSUM_SELECTION,
             },
+            ("--output-unframed-data",): {
+                "dest": "output_unframed_data",
+                "action": "store",
+                "nargs": "?",
+                "help": "Log unframed data to supplied file relative to log directory. Use '-' for standard out.",
+                "default": None,
+                "const": "unframed.log",
+                "required": False,
+            },
         }
         return {**adapter_arguments, **com_arguments}
 
@@ -699,9 +711,7 @@ def handle_arguments(self, args, **kwargs):
         args.app = Path(args.app) if args.app else Path(find_app(args.deployment))
         if not args.app.is_file():
             msg = f"F prime binary '{args.app}' does not exist or is not a file"
-            raise ValueError(
-                msg
-            )
+            raise ValueError(msg)
         return args
 
 
@@ -728,7 +738,7 @@ def get_arguments(self) -> Dict[Tuple[str, ...], Dict[str, Any]]:
                 "action": "store",
                 "required": False,
                 "type": int,
-                "nargs":'+',
+                "nargs": "+",
                 "help": f"only show {self.command_name} matching the given type ID(s) 'ID'; can provide multiple IDs to show all given types",
                 "metavar": "ID",
             },
diff --git a/src/fprime_gds/executables/comm.py b/src/fprime_gds/executables/comm.py
index 9a42f267..ff3d687e 100644
--- a/src/fprime_gds/executables/comm.py
+++ b/src/fprime_gds/executables/comm.py
@@ -21,6 +21,8 @@
 import signal
 import sys
 
+from pathlib import Path
+
 # Required adapters built on standard tools
 try:
     from fprime_gds.common.zmq_transport import ZmqGround
@@ -84,34 +86,59 @@ def main():
     # Set the framing class used and pass it to the uplink and downlink component constructions giving each a separate
     # instantiation
     framer_class = FpFramerDeframer
-    LOGGER.info("Starting uplinker/downlinker connecting to FSW using %s with %s", adapter, framer_class.__name__)
-    downlinker = Downlinker(adapter, ground, framer_class())
-    uplinker = Uplinker(adapter, ground, framer_class(), downlinker)
-
-    # Open resources for the handlers on either side, this prepares the resources needed for reading/writing data
-    ground.open()
-    adapter.open()
-
-    # Finally start the processing of uplink and downlink
-    downlinker.start()
-    uplinker.start()
-    LOGGER.debug("Uplinker and downlinker running")
-
-    # Wait for shutdown event in the form of a KeyboardInterrupt then stop the processing, close resources, and wait for
-    # everything to terminate as expected.
-    def shutdown(*_):
-        """Shutdown function for signals"""
-        uplinker.stop()
-        downlinker.stop()
+    LOGGER.info(
+        "Starting uplinker/downlinker connecting to FSW using %s with %s",
+        adapter,
+        framer_class.__name__,
+    )
+    discarded_file_handle = None
+    try:
+        if args.output_unframed_data == "-":
+            discarded_file_handle = sys.stdout.buffer
+        elif args.output_unframed_data is not None:
+            discarded_file_handle_path = (
+                Path(args.logs) / Path(args.output_unframed_data)
+            ).resolve()
+            try:
+                discarded_file_handle = open(discarded_file_handle_path, "wb")
+                LOGGER.info("Logging unframed data to %s", discarded_file_handle_path)
+            except OSError:
+                LOGGER.warning(
+                    "Failed to open %s. Unframed data will be discarded.",
+                    discarded_file_handle_path,
+                )
+        downlinker = Downlinker(
+            adapter, ground, framer_class(), discarded=discarded_file_handle
+        )
+        uplinker = Uplinker(adapter, ground, framer_class(), downlinker)
+
+        # Open resources for the handlers on either side, this prepares the resources needed for reading/writing data
+        ground.open()
+        adapter.open()
+
+        # Finally start the processing of uplink and downlink
+        downlinker.start()
+        uplinker.start()
+        LOGGER.debug("Uplinker and downlinker running")
+
+        # Wait for shutdown event in the form of a KeyboardInterrupt then stop the processing, close resources, and wait for
+        # everything to terminate as expected.
+        def shutdown(*_):
+            """Shutdown function for signals"""
+            uplinker.stop()
+            downlinker.stop()
+            uplinker.join()
+            downlinker.join()
+            ground.close()
+            adapter.close()
+
+        signal.signal(signal.SIGTERM, shutdown)
+        signal.signal(signal.SIGINT, shutdown)
         uplinker.join()
         downlinker.join()
-        ground.close()
-        adapter.close()
-
-    signal.signal(signal.SIGTERM, shutdown)
-    signal.signal(signal.SIGINT, shutdown)
-    uplinker.join()
-    downlinker.join()
+    finally:
+        if discarded_file_handle is not None and args.output_unframed_data != "-":
+            discarded_file_handle.close()
     return 0
 
 
diff --git a/src/fprime_gds/flask/static/js/datastore.js b/src/fprime_gds/flask/static/js/datastore.js
index 892f128f..918302a4 100644
--- a/src/fprime_gds/flask/static/js/datastore.js
+++ b/src/fprime_gds/flask/static/js/datastore.js
@@ -121,7 +121,18 @@ class FullListHistory extends ListHistory {
      * @param new_items: new items being to be process
      */
     send(new_items) {
-        this.store.splice(0, this.store.length, ...new_items);
+        // When the lists are not the same, update the stored list otherwise keep the list to prevent unnecessary bound
+        // data re-rendering.
+        if (this.store.length !== new_items.length) {
+            this.store.splice(0, this.store.length, ...new_items);
+            return;
+        }
+        for (let i = 0; i < Math.min(this.store.length, new_items.length); i++) {
+            if (this.store[i] !== new_items[i]) {
+                this.store.splice(0, this.store.length, ...new_items);
+                return;
+            }
+        }
     }
 }
 
diff --git a/src/fprime_gds/flask/static/js/vue-support/log.js b/src/fprime_gds/flask/static/js/vue-support/log.js
index f9127bd8..baa4fff7 100644
--- a/src/fprime_gds/flask/static/js/vue-support/log.js
+++ b/src/fprime_gds/flask/static/js/vue-support/log.js
@@ -21,9 +21,11 @@ let template = `
         <div class="my-3">
             <v-select id="logselect"
                     :clearable="true" :searchable="true"
-                    :filterable="true"  :options="options"
+                    :filterable="true"  :options="logs"
                     v-model="selected">
             </v-select>
+            <input name="scroll" type="checkbox" v-model="scroll" />
+            <label for="scroll">Scroll Log Output</label>
         </div>
     </div>
     <div class="fp-scroll-container">
@@ -31,6 +33,7 @@ let template = `
             <pre><code>{{ text }}</code></pre>
         </div>
     </div>
+    <div class="alert alert-danger" role="alert" v-if="error">{{ error }}</div>
 </div>
 `;
 
@@ -40,19 +43,10 @@ Vue.component('v-select', VueSelect.VueSelect);
 
 Vue.component("logging", {
     template: template,
-    data() {return {"selected": "", "logs": _datastore.logs, text: ""}},
+    data() {return {"selected": "", "logs": _datastore.logs, text: "", "scroll": true, "error": ""}},
     mounted() {
         setInterval(this.update, 1000); // Grab log updates once a second
     },
-    computed:{
-        /**
-         * Computes the appropriate log files available.
-         * @return {string[]}
-         */
-        options: function () {
-            return this.logs;
-        }
-    },
     methods: {
         /**
          * Updates the log data such that new logs can be displayed.
@@ -65,8 +59,22 @@ Vue.component("logging", {
             _loader.load("/logdata/" + this.selected, "GET").then(
                 (result) => {
                     _self.text = result[_self.selected];
-                    this.$el.scrollTop = this.$el.scrollHeight
-                }).catch((result) => {_self.text = "[ERROR] "+ result});
+                    // Update on next-tick so that the updated content has been drawn already
+                    _self.$nextTick(() => {
+                        let panes = _self.$el.getElementsByClassName("fp-scrollable");
+                        if (panes && _self.scroll)
+                        {
+                            panes[0].scrollTop = panes[0].scrollHeight;
+                        }
+                    });
+                    _self.error = "";
+                }).catch((result) => {
+                    if (result === "") {
+                        _self.error = "[ERROR] Failed to update log content.";
+                    } else {
+                        _self.error = "[ERROR] " + result + ".";
+                    }
+                });
         }
     }
 });

From 8677c646b8be817bf25073209bb7892a06c9f614 Mon Sep 17 00:00:00 2001
From: Thomas Boyer-Chammard <49786685+thomas-bc@users.noreply.github.com>
Date: Thu, 7 Dec 2023 11:28:25 -0800
Subject: [PATCH 6/6] Add issue creation redirection links (#154)

---
 .github/ISSUE_TEMPLATE/config.yml    |  8 ++++++++
 .github/ISSUE_TEMPLATE/do-not-use.md | 11 -----------
 2 files changed, 8 insertions(+), 11 deletions(-)
 create mode 100644 .github/ISSUE_TEMPLATE/config.yml
 delete mode 100644 .github/ISSUE_TEMPLATE/do-not-use.md

diff --git a/.github/ISSUE_TEMPLATE/config.yml b/.github/ISSUE_TEMPLATE/config.yml
new file mode 100644
index 00000000..3012790f
--- /dev/null
+++ b/.github/ISSUE_TEMPLATE/config.yml
@@ -0,0 +1,8 @@
+blank_issues_enabled: false
+contact_links:
+  - name: Open an Issue with F´
+    url: https://github.com/nasa/fprime/issues/new/choose
+    about: Issues about this repository are centrally managed in the core F´ repository
+  - name: F´ Community Discussions
+    url: https://github.com/nasa/fprime/discussions
+    about: Questions should be asked in the F´ Discussions
diff --git a/.github/ISSUE_TEMPLATE/do-not-use.md b/.github/ISSUE_TEMPLATE/do-not-use.md
deleted file mode 100644
index bea7e220..00000000
--- a/.github/ISSUE_TEMPLATE/do-not-use.md
+++ /dev/null
@@ -1,11 +0,0 @@
----
-name: Do not use
-about: Please use https://github.com/nasa/fprime/issues instead
-title: ''
-labels: bug
-assignees: ''
-
----
-# Do not use
-
-Please do not use this form. Issues should be posted to https://github.com/nasa/fprime/issues/new/choose