Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

http.js does not handle error response codes gracefully #27

Open
akhenry opened this issue Jan 24, 2018 · 0 comments
Open

http.js does not handle error response codes gracefully #27

akhenry opened this issue Jan 24, 2018 · 0 comments

Comments

@akhenry
Copy link
Collaborator

akhenry commented Jan 24, 2018

In brief, it assumes the presence of a response header which will not be there in the event of an error response. This causes an exception to be thrown for many valid http response codes, rather than a promise rejection which is the desired behavior.

See nasa/openmct#1882 (comment) for steps to recreate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant