Added new files to firestore folder #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ivanzvonkov
reviewed
Aug 5, 2022
scripts/firestore_delete/main.py
Outdated
| @@ -0,0 +1,35 @@ | |||
| #The given script creates a CLoud Function to that is triggered when an image file is deleted from the street2sat-uploaded bucket | |||
| #and then proceeds to delete the corresponding record from the Firestore DB. | |||
There was a problem hiding this comment.
nit: Inline comments should start with space: https://peps.python.org/pep-0008/#inline-comments
ivanzvonkov
reviewed
Aug 5, 2022
scripts/firestore_delete/main.py
Outdated
| doc.delete() | ||
| logger.info("Document has been deleted.") | ||
| else: | ||
| logger.info('No such record associated with the image file exists in the Firestore DB!') |
There was a problem hiding this comment.
Some of the logs end with punctuation and some don't, best to be consistent
ivanzvonkov
reviewed
Aug 5, 2022
| @@ -0,0 +1,3 @@ | |||
| # Function dependencies, for example: | |||
| # package>=version | |||
| google-cloud-firestore | |||
There was a problem hiding this comment.
Is the package not available by default in the Cloud Functions environment?
There was a problem hiding this comment.
No it is needed to be mentioned in the requirements.txt file, else we get an error
Code looks good! |
|
I have made the necessary changes as requested. Please check and let me know in case any additional changes are needed. |
Added deploy command for the street2sat delete function
ivanzvonkov
approved these changes
Aug 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Developed a Cloud Function that is triggered when an image file is deleted from the street2sat-uploaded bucket and then proceeds to delete the corresponding record from the Firestore DB.