New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix false positive tests #133

Closed

notdanilo opened this issue Nov 30, 2020 · 0 comments · Fixed by #199

Contributor

notdanilo commented Nov 30, 2020

As reported:

https://github.com/nash-io/openlimits/blob/master/tests/binance/ws_streams.rs -- tests are passing on timeout on ANY message from server (even ping/heartbeat/keepalive). Try to put wrong url and tests are passed.

notdanilo mentioned this issue

Rework tests #134

Closed

notdanilo linked a pull request

that will close this issue

Exchange impl #199

Merged

notdanilo closed this as completed in #199

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment