Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose client_order_id for nash #148

Closed
jankjr opened this issue Dec 16, 2020 · 4 comments · Fixed by #199
Closed

Expose client_order_id for nash #148

jankjr opened this issue Dec 16, 2020 · 4 comments · Fixed by #199
Assignees

Comments

@jankjr
Copy link
Contributor

jankjr commented Dec 16, 2020

We will need to expose the field in nash-rust as well.

@jankjr jankjr self-assigned this Dec 16, 2020
@Bi0max
Copy link

Bi0max commented Mar 3, 2021

@jankjr is it planned to implement client_order_id in the near future? Without it, it's very hard to track your orders. E.g. what if order is created, but returned "order_id" is not saved due to some bug or problem with DB (anything can happen). Then system will completely lose track of the order.

@jankjr
Copy link
Contributor Author

jankjr commented Mar 3, 2021

I think we added some support for clientIds some while back. But @notdanilo will know more.

@notdanilo
Copy link
Contributor

I need to check the support state.

@Bi0max
Copy link

Bi0max commented Mar 26, 2021

@jankjr @notdanilo . This functionality seems to be not implemented neither for JS, nor for Rust/Python clients.

@notdanilo notdanilo linked a pull request Nov 11, 2021 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants