Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

character justification of element names could be more flexible? #41

Open
natedey opened this issue Feb 27, 2024 · 3 comments
Open

character justification of element names could be more flexible? #41

natedey opened this issue Feb 27, 2024 · 3 comments

Comments

@natedey
Copy link
Owner

natedey commented Feb 27, 2024

Lines 41-44 of read_write_pdb.py:
try:
elsymbol = line[76:78]
except:
elsymbol = ''

might be problematic if characters are not properly right justified.
While right justified is the required format, RINRUS breaks if the characters are left justified, even if in the right fields.

I think
C
C
Cl

should work the same as
C
C
Cl

even if it doesn't strictly adhere to PDB formatting.
I don't understand why the code is misbehaving for the former situation...

@tsantaloci
Copy link
Collaborator

I don't see a difference between your two examples?

@natedey
Copy link
Owner Author

natedey commented Feb 28, 2024

hah yeah that didn't work right, did it?
first example misbehaves with
one letter characters on space 77, two letter characters on spaces 77 and 78
second example works with
one letter characters on space 78, two letter characters on spaces 77 and 78
I'll upload the two different pdbs later today

@natedey
Copy link
Owner Author

natedey commented Feb 28, 2024

pdb issues.zip
Run RINRUS with the PDB files included and the same driver input file below:
driver_input_example.txt

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants