Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stop using SETNX for locking #237

Open
thesecretmaster opened this issue Dec 20, 2018 · 2 comments
Open

Stop using SETNX for locking #237

thesecretmaster opened this issue Dec 20, 2018 · 2 comments
Labels
help wanted more info

Comments

@thesecretmaster
Copy link

According to the documentation, you shouldn't use SETNX for locking and instead use the Redlock algorithm as described here. Since there's already a redlock-rb gem, integrating it shouldn't be too hard.
@nateware
Copy link
Owner

Sounds interesting! Would definitely accept a patch for this. CC @tmsrjs

@allisonphillips
Copy link

@thesecretmaster Did you intend to link to this project? The redlock-rb project linked above hasn't had a commit since 2015.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
help wanted more info
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@nateware @allisonphillips @thesecretmaster