Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use regex to determine data validity for blockers #88

Open
nathan-weinberg opened this issue Apr 27, 2020 · 3 comments
Open

Use regex to determine data validity for blockers #88

nathan-weinberg opened this issue Apr 27, 2020 · 3 comments
Labels
low priority This task is of low priority RFE New feature or request

Comments

@nathan-weinberg
Copy link
Owner

Currently, get_bugs_set() and get_jira_set() assume correct formatting of blockers within blockers.yaml. Since we have certain expectations of what kind of data we are looking for (seven digit number for bugs, 'RHOS(something)-(four digit number)' for tickets) we can use a regex to validate the data retrieved by these functions.

@nathan-weinberg nathan-weinberg added RFE New feature or request low priority This task is of low priority labels Apr 27, 2020
@EliadCohen
Copy link
Collaborator

I think the data validation might need to have it's own config file. As you mention, the use of RHOS[.]-[0-9] is downstream-specific and even then is openstack specific. I like the idea but from a design point of view think this should be a user entered regex in a config file. But I also think users should be able to opt for no-validation.

@nathan-weinberg
Copy link
Owner Author

Maybe a couple of optional fields in config.yaml - if no value is set the regex validation is not used?

@EliadCohen
Copy link
Collaborator

I'd say that would work @nathan-weinberg

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
low priority This task is of low priority RFE New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants