Attempt to remove the subject_transform_dest struct key #861
Conversation
| } else if source.FilterSubject != "" && source.SubjectTransformDest != "" { | ||
| edge.Label(source.FilterSubject + " to " + source.SubjectTransformDest) | ||
| } else if len(source.SubjectTransforms) == 1 { | ||
| edge.Label(source.SubjectTransforms[0].Source + " to " + source.SubjectTransforms[0].Destination) |
There was a problem hiding this comment.
Seems we never did anything here if SubjectTransforms were set at all? So I limited the change to just if its exactly 1
There was a problem hiding this comment.
I think not handling SubjectTransforms here was simply an omission, so no need to limit it to just == 1, it should just be if > 1
There was a problem hiding this comment.
not convinced that would work, because here the label pairs are to->dest and it needs to handle many. Just using a >1 here would not look good or be complete
I think I will leave it as is for release, we can fix later to handle multiple better
There was a problem hiding this comment.
Maybe put something like "multiple" in the filter and destinations columns if there's more than 1 in SubjectTransforms?
There was a problem hiding this comment.
Then find a way to display more than one in the table format later
There was a problem hiding this comment.
These edges are here are used to produce a dot graph, not for the table, its not something to fix today I am afraid.
There was a problem hiding this comment.
Fixing this to show multiple sources etc, possible of course but more surgery than I want now. I will release 0.1.0, we can do 0.1.1 not long in the future to add these
ripienaar
force-pushed
the
subject_transform_dest
branch
3 times, most recently
from
e405e4e to
2d1d369
Compare
Signed-off-by: R.I.Pienaar <[email protected]>
ripienaar
force-pushed
the
subject_transform_dest
branch
from
2d1d369 to
8de8703
Compare
No description provided.