Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ADDED] consumer add when prompting for subject filter(s) can parse the user input as a comma or space separated list of subject filters #883

Merged
merged 2 commits into from
Sep 28, 2023

Conversation

jnmoyne
Copy link
Contributor

@jnmoyne jnmoyne commented Sep 27, 2023

Added to consumer add: when prompting for subject filter(s) can parse the user input as a comma or space separated list of subject filters.

… the user input as a comma or space separated list of subject filters.

Signed-off-by: Jean-Noël Moyne <[email protected]>
@jnmoyne jnmoyne requested a review from ripienaar September 27, 2023 18:41
@ripienaar
Copy link
Collaborator

This is probably not [ADDED] but rather whatever we use to indicate fixed. Personally I dont really want those prefixes in this repo they dont add much value

@jnmoyne
Copy link
Contributor Author

jnmoyne commented Sep 28, 2023

Ok, just in the habit of using those prefixes because that's how they want it for the client libraries, but won't use them for this repo from now on.

@jnmoyne jnmoyne merged commit 961eaf2 into main Sep 28, 2023
4 checks passed
@jnmoyne jnmoyne deleted the jnm/fix_consumer_add_multifilter_prompt branch September 28, 2023 17:48
ripienaar pushed a commit that referenced this pull request Oct 3, 2023
… the user input as a comma or space separated list of subject filters. (#883)

Signed-off-by: Jean-Noël Moyne <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants