Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use PGP for signing comments. #50

Open
da2ce7 opened this issue Oct 7, 2021 · 3 comments
Open

Use PGP for signing comments. #50

da2ce7 opened this issue Oct 7, 2021 · 3 comments
Labels
best-practices Making Use of Generally Accepted Best Practices security Improve Project Security and Related Aspects

Comments

@da2ce7
Copy link
Contributor

da2ce7 commented Oct 7, 2021

The use of PGP for signing comments is a good and simple way to improve the confidence of the authenticity of the commits.

It is considered good practice as it makes it very hard to impersonate the author of any particular comment.

Github has good integration with this feature: https://docs.github.com/en/authentication/managing-commit-signature-verification/about-commit-signature-verification

@da2ce7 da2ce7 added best-practices Making Use of Generally Accepted Best Practices security Improve Project Security and Related Aspects labels Oct 7, 2021
@MCM-Mike
Copy link
Member

MCM-Mike commented Oct 7, 2021

When using Visual Studio Code:

Once you have enabled GPG verification for Codespaces, you also must append -S to each commit in order for it to be signed. To do this in Visual Studio Code, ensure the "Git: Enable Commit Signing" option is enabled from the Settings.

But I like the idea in general to use it across our projects, its a bit more work, but as @da2ce7 mention in #50 (comment) is a simple way to improve the confidence of the authenticity of the comments.

@josecelano
Copy link
Member

@da2ce7 I suppose you meant "commits" instead of "comments". I do not find any option to sign comments.

@cgbosse and I already enabled it some days ago. @yeraydavidrodriguez is also going to do it.

I was looking for an option to "force" all commits to be signed using GitHub settings, but I have not found anything.

I will also create a PR to add my key (#52)

@yeraydavidrodriguez
Copy link
Collaborator

Setting up GPG in Mac OS to sign commits may be sometimes difficult.
There are plenty information there, like those two helpful stack overflow threads:

In my case, a bug in GPG produced a "Inappropriate ioctl for device" error, and the fix was this command:

export GPG_TTY=$(tty)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
best-practices Making Use of Generally Accepted Best Practices security Improve Project Security and Related Aspects
Projects
None yet
Development

No branches or pull requests

4 participants