Allow the user to overwrite the default git committer name and email

[josecelano]

The action is getting the committer info (name and email) from git configuration (commit command argument/env-var, local config, global config, system config). The same way Git does.

For testing, we are using a specific committer (A committer <[email protected]>). We do it using options when we build the SimpleGit instance:

export async function newSimpleGitWithCommitterIdentity(
  gitRepoDir: GitRepoDir
): Promise<SimpleGit> {
  const options: Partial<SimpleGitOptions> = {
    baseDir: gitRepoDir.getDirPath(),
    config: [
      `user.name=${testConfiguration().git.user.name}`,
      `user.email=${testConfiguration().git.user.email}`
    ]
  }
  const git = simpleGit(options)
  return git
}

All you add to the config attribute will be passed to git commit command withe the option -c.

Should we allow the action user to overwrite the commit with a new input @yeraydavidrodriguez @da2ce7 ?

git_committer_name
git_committer_email

Right now it's possible to overwrite it by using environment variables which is the other what Git allows you to do it:

GIT_COMMITTER_NAME
GIT_COMMITTER_EMAIL

We are passing all process env vars to the child git process.

I think we can implement it. It's a very easy feature and it could be helpful in some cases.

[da2ce7]

Hello Jose, I trust that if you think that it is an easy and good feature, then go ahead and implement it. 👍 In our case, we only care about the author, as we rewrite the commiter automatically when we sign the commits from the main workflows. 😊 Cam. Von meinem iPhone gesendet

…

Am 21/2/2022 um 13:18 schrieb Jose Celano ***@***.***>:  The action is getting the committer info (name and email) from git configuration (commit command argument/env-var, local config, global config, system config). The same way Git does. For testing, we are using a specific committer (A committer ***@***.***>). We do it using options when we build the SimpleGit instance: export async function newSimpleGitWithCommitterIdentity( gitRepoDir: GitRepoDir ): Promise<SimpleGit> { const options: Partial<SimpleGitOptions> = { baseDir: gitRepoDir.getDirPath(), config: [ `user.name=${testConfiguration().git.user.name}`, `user.email=${testConfiguration().git.user.email}` ] } const git = simpleGit(options) return git } All you add to the config attribute will be passed to git commit command withe the option -c. Should we allow the action user to overwrite the commit with a new input @yeraydavidrodriguez @da2ce7 ? git_committer_name git_committer_email Right now it's possible to overwrite it by using environment variables which is the other what Git allows you to do it: GIT_COMMITTER_NAME GIT_COMMITTER_EMAIL We are passing all process env vars to the child git process. I think we can implement it. It's a very easy feature and it could be helpful in some cases. — Reply to this email directly, view it on GitHub, or unsubscribe. Triage notifications on the go with GitHub Mobile for iOS or Android. You are receiving this because you were mentioned.

[josecelano]

I've just moved it to milestone 1.1.0 int the roadmap. Even if it's simple maybe it is not useful. I can't think now a workflow example where you might need to use a different committer in the same workflow. We can wait until we or someone else has the need.

I also tagged it as good-first-issue. It could be a good opportunity to collaborate with the repo.