Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature flagging: Add local feature flagging implementation that doesn't rely on evidently #263

Closed
aligg opened this issue Dec 8, 2023 · 0 comments · Fixed by #278
Closed

Feature flagging: Add local feature flagging implementation that doesn't rely on evidently #263

aligg opened this issue Dec 8, 2023 · 0 comments · Fixed by #278
Assignees
@jcq
Labels
feature New feature or request
Milestone
Feature flags

Comments

@aligg
Copy link
Contributor

aligg commented Dec 8, 2023

What's the task?

In a past PR we added support for feature flagging with AWS Evidently and included a stubbed local feature flagging class: LocalFeatureFlagManager. Currently the class simply defaults to false.

The work of this ticket is to add a local feature flag implementation - we could leverage env variables, query params, or config files.
@aligg aligg added the feature New feature or request label Dec 8, 2023
@aligg aligg mentioned this issue Dec 8, 2023
Merged
@sawyerh sawyerh added this to the Feature flags milestone Dec 12, 2023
@jcq jcq self-assigned this Jan 9, 2024
@jcq jcq mentioned this issue Jan 10, 2024
Merged
sawyerh added a commit that referenced this issue Apr 18, 2024
@jcq @sawyerh
Support mocking feature flags and add test coverage (#278)
184df2e 
## Ticket

Resolves #263

---------

Co-authored-by: Sawyer <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jcq jcq

Labels
feature New feature or request
Projects
None yet
Milestone
Feature flags
Development

Successfully merging a pull request may close this issue.

Added basic support for local feature flagging navapbc/template-application-nextjs
3 participants
@sawyerh @jcq @aligg