Update to liveview 1.0 #687
Conversation
|
Still need to wait for sentry to be updated so I can remove the the |
|
Thanks! <3 I will take a look tomorrow. We will probably do the |
|
FYI Sentry has been updated to use LiveView 1.0 . Would love to see Backpex on LiveView 1.0 ;) |
| @@ -427,7 +427,11 @@ defmodule Backpex.Fields.Upload do | |||
| upload_key = assigns.field_options.upload_key | |||
| uploads_allowed = not is_nil(assigns.field_uploads) | |||
| translate_error_fun = Map.get(assigns.field_options, :translate_error, &Function.identity/1) | |||
| form_errors = BackpexForm.translate_form_errors(assigns.form[assigns.name], translate_error_fun) | |||
|
|
|||
| errors = | |||
There was a problem hiding this comment.
@thomasfortes I guess we have the same error also in the Upload field. I put avatar in the required_fields list in user.ex and it immediately shows that an upload is required even though I did not use the upload.
We also have this issue in the multi select. You can see it in the “Send email” action modal (users table), but we had this multi select issue before your LiveView 1.0 update so we could fix this in another MR.
There was a problem hiding this comment.
Yeah, I'm not sure if I'm fully satisfied with the solution in the commit so let me know what you think, the upload changes are put into the changes by a user provided function, to avoid breaking user code I had to create a hidden field to keep track if the field has been manipulated and do some params manipulation in the put_upload_change function in the form_component.ex, the variables are terribly named and could use some kindness, it also probably can be cleaned a bit, but as it is it should "work".
There's a caveat, if you insert an image and then remove it it will not trigger the error until you interact with another field, which isn't perfect but it is better than the situation we have right now where it triggers when you interact with any field, but even this caveat should be solvable fixing the cancel-entry event.
Happy holidays :)
The first commit closes #404 and the following one format the code to use the new template interpolation with brackets.