Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unnecessary overflow in the admin #776

Open
clifinger opened this issue Jan 16, 2025 · 4 comments
Open

Unnecessary overflow in the admin #776

clifinger opened this issue Jan 16, 2025 · 4 comments

Comments

@clifinger
Copy link

Describe the bug

Make an overflow even if we don't have overflowing content in main tag:

<main class="h-[calc(100vh-4rem)] mt-[4rem] flex flex-col"> 

To Reproduce
Respect the Get started Documentation

Expected behavior
No overflow by adding flex-1 class to main:

<main class="h-[calc(100vh-4rem)] mt-[4rem] flex flex-1 flex-col"> 

Screenshots
Screenshot 2025-01-16 144314

Please complete the following information:

  • OS: x86_64 GNU/Linux
  • Browser: Chrome
  • Elixir Version: 1.18.1-otp-27
  • Backpex Version: 0.10.0

Additional context
Sorry but I don't have time to make a PR

@DavidOliver
Copy link

This may not be directly related to this issue, but in case others stumble into the same situation that I did...

When I had unwanted vertical overflow, it turned out to be my app styles which were applied via the root layout's stylesheet - probably padding on body or similar.

I'm now using two separate root layouts - one for admin and one for app - each with their own CSS stylesheets. router.ex:

  pipeline :browser do
    # ...
    plug :put_root_layout, html: {MyAppWeb.Layouts, :app_root}
    # ...
  end

  pipeline :admin do
    plug :put_root_layout, html: {MyAppWeb.Layouts, :admin_root}
  end

  scope "/admin", ERWeb do
    pipe_through [:browser, :admin]

    backpex_routes()

    live_session :default, on_mount: Backpex.InitAssigns do
      live_resources "/posts", PostLive
    end
  end

@Flo0807
Copy link
Collaborator

Flo0807 commented Feb 15, 2025

Hey@clifinger!

Can you verify that the issue is related to your root layout?

@clifinger
Copy link
Author

Just keep open, I need to make a new project for a client by tuesday, thank you guys

@Flo0807
Copy link
Collaborator

Flo0807 commented Mar 6, 2025

Just keep open, I need to make a new project for a client by tuesday, thank you guys

Hey, do you have any updates on this? @clifinger

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants