Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disabling sprites test gives incorrect results #357

Open
alyosha-tas opened this issue Feb 19, 2024 · 1 comment
Open

Disabling sprites test gives incorrect results #357

alyosha-tas opened this issue Feb 19, 2024 · 1 comment
Assignees
Labels

Comments

@alyosha-tas
Copy link

I started making tests for examining the effect of disabling sprites midscanline. Currently Nanoboy Advance renders addtional scanlines of sprites even when disabled.

Here is the test: https://github.com/alyosha-tas/gba-tests/blob/master/ppu/Sprite_Disable_Midline.gba

The results should look like this:

correct_boxes

@fleroviux
Copy link
Member

fleroviux commented Feb 19, 2024

This probably is related to the weird latching of DISPCNT enable bits that I never understood why the hardware even behaves the way it does. Apparently back when I researched this I decided that sprites unlike backgrounds should check only the latched DISPCNT enable bits and not AND them with the current enable bits unlike backgrounds... I'm not sure why I concluded that but it's likely why the test is breaking

@fleroviux fleroviux self-assigned this Feb 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants