Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Explain Docker secrets handling #11

Open
nbarbettini opened this issue Sep 28, 2017 · 1 comment
Open

Explain Docker secrets handling #11

nbarbettini opened this issue Sep 28, 2017 · 1 comment
Milestone

Comments

@nbarbettini
Copy link
Owner

Got cut from 1.0: the deployment chapter should explain how to handle secrets in a Docker environment. Right now, it tells you to disable Facebook login if you're on Docker (which isn't ideal).

@nbarbettini nbarbettini added this to the 1.1 milestone Sep 28, 2017
@GarethOates
Copy link

I've just ran through all of your book just now and I've enjoyed it very much. Thank you for taking the time to create such a well structured and well paced instruction guide.

Am I right in thinking that one way to pass the app Id and secret into the container is to set the ID and Secret as environmental variables when you run the build command, and in the Dockerfile run the dotnet user-secrets set Facebook:AppId ENV_VAR1 like that?

Is this an acceptable approach?

@nbarbettini nbarbettini modified the milestones: 1.1, 2.0 Jan 15, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants