Skip to content

Commit 42b202d

Browse files
authored
Merge pull request #102 from ncats/CVValidator_2613
filter type before cast
2 parents b51f6f6 + cc36f65 commit 42b202d

File tree

1 file changed

+7
-3
lines changed

1 file changed

+7
-3
lines changed

gsrs-module-substances-core/src/main/java/ix/ginas/utils/validation/validators/CVFragmentStructureValidator.java

+7-3
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,8 @@ private class FragmentChanges{
4343
@Override
4444
public void validate(ControlledVocabulary newCV, ControlledVocabulary oldCV, ValidatorCallback callback) {
4545

46-
List<FragmentVocabularyTerm> invalidUpdateTerms =newCV.getTerms().stream()
46+
List<FragmentVocabularyTerm> invalidUpdateTerms =newCV.getTerms().stream()
47+
.filter(term-> term instanceof FragmentVocabularyTerm)
4748
.map(term->(FragmentVocabularyTerm)term)
4849
.filter(term->!Optional.ofNullable(term.getFragmentStructure()).isPresent()
4950
|| !Optional.ofNullable(term.getDisplay()).isPresent()
@@ -58,6 +59,7 @@ public void validate(ControlledVocabulary newCV, ControlledVocabulary oldCV, Val
5859
FragmentChanges changes = getAddedUpdatedDeletedTerms(newCV, oldCV);
5960

6061
Map<String, List<String>> hashLookup = newCV.getTerms().stream()
62+
.filter(term-> term instanceof FragmentVocabularyTerm)
6163
.map(key->(FragmentVocabularyTerm)key)
6264
.map(f->Tuple.of(getHash(f), f.getValue()))
6365
.filter(t->t.k().isPresent())
@@ -130,7 +132,8 @@ private FragmentChanges getAddedUpdatedDeletedTerms(ControlledVocabulary newCV,
130132

131133
FragmentChanges fragmentChanges = new FragmentChanges();
132134

133-
List<FragmentVocabularyTerm> termsAfterUpdate =newCV.getTerms().stream()
135+
List<FragmentVocabularyTerm> termsAfterUpdate =newCV.getTerms().stream()
136+
.filter(term->term instanceof FragmentVocabularyTerm)
134137
.map(term->(FragmentVocabularyTerm)term)
135138
.collect(Collectors.toList());
136139

@@ -140,7 +143,8 @@ private FragmentChanges getAddedUpdatedDeletedTerms(ControlledVocabulary newCV,
140143
return fragmentChanges;
141144
}
142145

143-
List<FragmentVocabularyTerm> termsBeforeUpdate = oldCV.getTerms().stream()
146+
List<FragmentVocabularyTerm> termsBeforeUpdate = oldCV.getTerms().stream()
147+
.filter(term-> term instanceof FragmentVocabularyTerm)
144148
.map(term->(FragmentVocabularyTerm)term)
145149
.collect(Collectors.toList());
146150

0 commit comments

Comments
 (0)