-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New cloneCall option to more closely match immunarch
options?
#396
Comments
Hey @jeremymsimon I think you make a great point - that ideally there would be a matching option between the 2 workflows - immunarch and scRepertoire. I think the fundamental problem with making the change would be interupting/changing clonal definitions for users, which makes me hesitate. I think a work around would be to modify the CTstrict column using something like the stringr package. As along as the header is the same, there should be no break in any of the downstream functions. I will think more on this though - I have been really interested in making scRepertoire as compatible with other workflows. Thanks, |
That would be great! Keep me posted, happy to help with testing as well |
Hi @ncborcherding any updates on this? |
I think for the near term, we won't update the definition of strict clonotype - I do not want to change definitions for the majority of users. I will update scRepertoire for a new release through bioconductor 3.21 Nick |
Hey @ncborcherding - totally understand not being destructive about the change. Do you think it's possible to introduce an alternative matching criteria choice that could potentially align with how immunarch does it in |
Hi @ncborcherding I'm wondering if it's at all possible to include another option in
cloneCall
to be CDR3 AA + V + J, which would more closely matchimmunarch
'sTrackClonotypes(aa+v+j)
function.strict
in your options includes theC
gene, which is one notch more stringent, andaa
of course only includes the CDR3 amino acid sequence alone.Since we're using both it would be amazing if we could be sure all groupings are done consistently
Thanks!
The text was updated successfully, but these errors were encountered: