Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New cloneCall option to more closely match immunarch options? #396

Closed
jeremymsimon opened this issue Aug 8, 2024 · 5 comments
Closed

New cloneCall option to more closely match immunarch options? #396

jeremymsimon opened this issue Aug 8, 2024 · 5 comments
Labels
enhancement New feature or request

Comments

@jeremymsimon
Copy link

Hi @ncborcherding I'm wondering if it's at all possible to include another option in cloneCall to be CDR3 AA + V + J, which would more closely match immunarch's TrackClonotypes(aa+v+j) function.

strict in your options includes the C gene, which is one notch more stringent, and aa of course only includes the CDR3 amino acid sequence alone.

Since we're using both it would be amazing if we could be sure all groupings are done consistently

Thanks!

@ncborcherding
Copy link
Owner

Hey @jeremymsimon

I think you make a great point - that ideally there would be a matching option between the 2 workflows - immunarch and scRepertoire. I think the fundamental problem with making the change would be interupting/changing clonal definitions for users, which makes me hesitate.

I think a work around would be to modify the CTstrict column using something like the stringr package. As along as the header is the same, there should be no break in any of the downstream functions.

I will think more on this though - I have been really interested in making scRepertoire as compatible with other workflows.

Thanks,
Nick

@ncborcherding ncborcherding added the enhancement New feature or request label Aug 8, 2024
@jeremymsimon
Copy link
Author

That would be great! Keep me posted, happy to help with testing as well

@jeremymsimon
Copy link
Author

Hi @ncborcherding any updates on this?

@ncborcherding
Copy link
Owner

@jeremymsimon

I think for the near term, we won't update the definition of strict clonotype - I do not want to change definitions for the majority of users.

I will update scRepertoire for a new release through bioconductor 3.21

Nick

@jeremymsimon
Copy link
Author

Hey @ncborcherding - totally understand not being destructive about the change. Do you think it's possible to introduce an alternative matching criteria choice that could potentially align with how immunarch does it in TrackClonotypes ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants