Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can't capitalize custom variables in cloneCall #405

Closed
chloetu-dfci opened this issue Sep 13, 2024 · 2 comments
Closed

Can't capitalize custom variables in cloneCall #405

chloetu-dfci opened this issue Sep 13, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@chloetu-dfci
Copy link

Hi @ncborcherding!

I noticed that using a capitalized variable name in combineExpression's cloneCall doesn't work! ie: combineExpression(input, sc.obj, cloneCall="vdjaa") works, but combineExpression(input, sc.obj, cloneCall="VDJaa") won't.

I think this happens in the function .theCall– the cloneCall variable is converted to lowercase via .convertClonecall before there's a check for the variable in the inputs columns.

Thanks!

@ncborcherding ncborcherding added the bug Something isn't working label Sep 16, 2024
@ncborcherding ncborcherding self-assigned this Sep 16, 2024
@ncborcherding
Copy link
Owner

Thanks will get it updated in the next commit!

Nick

ncborcherding added a commit that referenced this issue Sep 19, 2024
Fixing custom clone calling via issue #405
@ncborcherding
Copy link
Owner

Got the fix up and running in the dev version, need to do more testing before I get it into the main branch and bioconductor.

Thanks again

Nick

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants