Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] clonalLength() exports NULL when group.by and a single chain are provided #412

Closed
pwwang opened this issue Oct 8, 2024 · 2 comments

Comments

@pwwang
Copy link
Contributor

pwwang commented Oct 8, 2024

library(scRepertoire)

data(contig_list)
data <- combineTCR(contig_list)
data <- addVariable(data, variable.name = "Type",
     variables = rep(c("B", "L"), each = 4))

df <- clonalLength(data, group.by = "Type", chain = "TRB", exportTable = TRUE)
df  # NULL
df <- clonalLength(data, group.by = "Type", chain = "both", exportTable = TRUE)
head(df)
#   length                               CT Type values
# 1     25       CGCSNDYKLSF_CASSLTDRTYEQYF    B     S1
# 2     31 CAYRSAQAGGTSYGKLTF_CAISEQGKGELFF    B     S1
# 3     31 CVVSDNTGGFKTIF_CASSVRRERANTGELFF    B     S1
# 4     31 CVVSDNTGGFKTIF_CASSVRRERANTGELFF    B     S1
# 5     13                 CAVRGEGFQKLVF_NA    B     S1
# 6     31 CVVSDNTGGFKTIF_CASSVRRERANTGELFF    B     S1
ncborcherding added a commit that referenced this issue Oct 8, 2024
Fix issue with single chain per #412
Removed code that was pre-data.wrangle() internal function
@ncborcherding
Copy link
Owner

ncborcherding commented Oct 8, 2024

Did not see this PR, already pushed something into the dev branch. Added a little more expanded fix/cleaning so I will decline your PR, but I really appreciate it!

@pwwang
Copy link
Contributor Author

pwwang commented Oct 8, 2024

No worries. Thanks for the prompt fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants