Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor combineTCR fix & refactor combineBCR #450

Merged
merged 11 commits into from
Nov 26, 2024

Conversation

Qile0317
Copy link
Collaborator

@Qile0317 Qile0317 commented Nov 23, 2024

Switched back to using the $barcode syntax for selecting the barcode column instead of assuming its in the first position. Encountered this issue when working with a custom version of the data I manipulated.

@Qile0317 Qile0317 marked this pull request as ready for review November 23, 2024 11:01
@Qile0317 Qile0317 self-assigned this Nov 23, 2024
@Qile0317 Qile0317 added the enhancement New feature or request label Nov 23, 2024
@Qile0317 Qile0317 changed the title Minor combineTCR fix Minor combineTCR fix & force samples argument in combineBCR Nov 24, 2024
@ncborcherding
Copy link
Owner

only change is that the sample argument was disallowed to be null and the stop call was removed when it is

You will need to make sure this doesn't cause errors when combining multiple BCR experiments. The reason sample was required was to avoid duplicate barcodes when using igraph.

@Qile0317
Copy link
Collaborator Author

Qile0317 commented Nov 25, 2024

only change is that the sample argument was disallowed to be null and the stop call was removed when it is

You will need to make sure this doesn't cause errors when combining multiple BCR experiments. The reason sample was required was to avoid duplicate barcodes when using igraph.

Ok - I may be completely mistaken but im a little confused on how immediately injecting a stop call when samples = NULL isn't equivalent for any use case but I'll revert.

@Qile0317
Copy link
Collaborator Author

@ncborcherding re-added functionality for samples = NULL.

@Qile0317 Qile0317 changed the title Minor combineTCR fix & force samples argument in combineBCR Minor combineTCR fix & refactor combineBCR Nov 26, 2024
@Qile0317 Qile0317 changed the title Minor combineTCR fix & refactor combineBCR Minor combineTCR fix & refactor combineBCR Nov 26, 2024
@ncborcherding ncborcherding merged commit 7d6ea5e into ncborcherding:dev Nov 26, 2024
1 check passed
@ncborcherding
Copy link
Owner

Sorry I think I was confused with the NULL, i see what you did now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants