-
Notifications
You must be signed in to change notification settings - Fork 55
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor combineTCR
fix & refactor combineBCR
#450
Conversation
samples
argument in combineBCR
You will need to make sure this doesn't cause errors when combining multiple BCR experiments. The reason sample was required was to avoid duplicate barcodes when using igraph. |
Ok - I may be completely mistaken but im a little confused on how immediately injecting a stop call when samples = NULL isn't equivalent for any use case but I'll revert. |
@ncborcherding re-added functionality for samples = NULL. |
samples
argument in combineBCR
combineBCR
combineBCR
combineTCR
fix & refactor combineBCR
Sorry I think I was confused with the NULL, i see what you did now. |
Switched back to using the
$barcode
syntax for selecting the barcode column instead of assuming its in the first position. Encountered this issue when working with a custom version of the data I manipulated.