massively sped up combineTCR
with Rcpp
#276
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
combineTCR
is one of the most important functions but it's kinda slow, running originally in ~ 24 seconds forcontig_list
on my device. I used theprofvis
profiling library to see the speed bottlenecks, and see that.parseTCR
is the main time consumer. Looking deeper into the function, this PR solves one of them - finding the indicies of barcodes ofCon.df$barcode
of lengthN
that are indata2$barcode
of lengthM
, by constructing a barcode index inO(N+M)
time in Rcpp. This has cut the runtime down to ~17 seconds. I'm working on fully re-implementing.parseTCR
in Rcpp atm to see if theres another time increase.