Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid page reload when user attempts to login #213

Open
itaditya opened this issue Jul 3, 2017 · 4 comments
Open

Avoid page reload when user attempts to login #213

itaditya opened this issue Jul 3, 2017 · 4 comments

Comments

@itaditya
Copy link
Contributor

itaditya commented Jul 3, 2017

Currently, the login process requires the browser to reload. This is annoying when the user fails to login due to incorrect credentials or some other reason.

@itaditya itaditya changed the title Avoid page reload when user logs in Avoid page reload when user attempts to login Jul 3, 2017
@deshraj
Copy link
Member

deshraj commented Jul 4, 2017

@itaditya can you please suggest a better workflow for this? When we were building the connect, then we tried to change this but due to constrained setting of allauth package, we could not do it. Please let me know if you suggest something better.

@itaditya
Copy link
Contributor Author

itaditya commented Jul 5, 2017

@deshraj , I read about django-allauth but I'm unable to understand how it works at the core. So if you can give a little idea of it's mechanics then it would be great. Also, some questions -
does it use JWT?
does it uses page reload to save session data in the browser's cookie or whatever..

@deshraj
Copy link
Member

deshraj commented Jul 5, 2017

I think it would require a non-trivial amount of effort and time to change the workflow. Also, the time and effort that you guys will spend in implementing this are not worth it. Please feel free to close it. :)

@itaditya
Copy link
Contributor Author

itaditya commented Jul 5, 2017

I was just thinking, that we can ease the process when the login attempt fails like incorrect data or something else, if there are no such issues then django-allauth may proceed as usual

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants