Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec Delete fails, throws an error #334

Open
bodom0015 opened this issue Jan 5, 2021 · 1 comment
Open

Spec Delete fails, throws an error #334

bodom0015 opened this issue Jan 5, 2021 · 1 comment

Comments

@bodom0015
Copy link
Member

When attempting to delete a spec that the user previously added to their personal (catalog=user), nothing appears to happen and the spec is not actually deleted.

Note that in this case, the modal does behave correctly and remains open until the operation has completed successfully.

The error printed to the console can be seen below:

VM6:1 DELETE https://www.hub.cheesehub.org/api/services/ddosclassification 404
angular.js:15635 Response error encountered: https://www.hub.cheesehub.org/api/services/ddosclassification
services.js:215 2021-01-05 11:59:13 [ERROR] {"message":"Response error encountered: https://www.hub.cheesehub.org/api/services/ddosclassification"}
@bodom0015
Copy link
Member Author

bodom0015 commented Jan 13, 2021

It looks like the Workbench UI needs to send the catalog=user form parameter along with its request to delete from a user's personal catalog: https://github.com/nds-org/ndslabs/blob/develop/apiserver/cmd/server/server.go#L1261

Inspecting the request from the browser developer console, it looks like this parameter is no longer being sent to the server?
More testing is needed to determine if this is indeed the case

EDIT: Digging deeper, it looks like the Swagger docs for the DELETE /services/:key endpoint are also missing the catalog enum parameter

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant