Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Color for comments is difficult to read on some displays / view angles #7

Open
jackrobbins1 opened this issue Aug 8, 2022 · 1 comment

Comments

@jackrobbins1
Copy link

The gray color used for comments in both the light and dark versions of this theme is difficult to read against the background color. This issue may be more noticeable on monitors with low contrast ratios (I'm using an HP 27Q monitor).

The gray color for comments is easier to read on better performing displays like the one built in to my MacBook Air. However, I think some subtle tweaking of this color or adding more theme options with an alternate comment color would solve this problem.

@jackrobbins1 jackrobbins1 changed the title Color for comments is difficult to read on Color for comments is difficult to read on some displays / certain view angles. Aug 8, 2022
@jackrobbins1 jackrobbins1 changed the title Color for comments is difficult to read on some displays / certain view angles. Color for comments is difficult to read on some displays / view angles Aug 8, 2022
@nealmckee
Copy link
Owner

nealmckee commented Aug 8, 2022

When designing the colours, I was targeting a decently well calibrated, relatively recent display with full sRGB coverage. If this is not what you‘re working with, the comment colour will likely not be the only issue you run into.

Do you feel like it‘s fine on the MacBookAir?

The high(est) contrast version should be compensating for this already, do you have the same issue using the contrast++ version? (Unfortunately the design constraints do not allow for a higher contrast light version)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants