Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of pwasm_utils #1376

Closed
MaksymZavershynskyi opened this issue Sep 29, 2019 · 3 comments
Closed

Get rid of pwasm_utils #1376

MaksymZavershynskyi opened this issue Sep 29, 2019 · 3 comments
Assignees
@lexfrl @mikhailOK
Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)
Milestone
Outdated

Comments

@MaksymZavershynskyi
Copy link
Contributor

Current Wasmer can inject gas metering and canonize or even prohibit floats. This is almost everything that we need pwasm_utils for. Consider removing pwasm_utils and using these features from Wasmer.
@MaksymZavershynskyi MaksymZavershynskyi added the P-high Priority: High label Sep 29, 2019
@weekly-digest weekly-digest bot mentioned this issue Oct 4, 2019
Closed
@lexfrl lexfrl self-assigned this Oct 7, 2019
@MaksymZavershynskyi MaksymZavershynskyi added P-critical Priority: critical and removed P-high Priority: High labels Nov 1, 2019
@MaksymZavershynskyi
Copy link
Contributor Author

Bumping to priority 0, not that we have encountered bugs with pwasm-utisl.

@MaksymZavershynskyi MaksymZavershynskyi added A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) runtime-stability and removed P-critical Priority: critical labels Nov 19, 2019
@MaksymZavershynskyi MaksymZavershynskyi changed the title Consider getting rid of pwasm_utils Get rid of pwasm_utils Nov 19, 2019
@MaksymZavershynskyi
Copy link
Contributor Author

Should also make the following issue easier to fix: #1344

@ilblackdragon ilblackdragon added this to the MainNet milestone Dec 8, 2019
@MaksymZavershynskyi
Copy link
Contributor Author

We probably won't get rid of it, since the license is Apache 2.0

@tzemanovic tzemanovic mentioned this issue Mar 10, 2021
Closed
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lexfrl lexfrl

@mikhailOK mikhailOK

Labels
A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc)
Projects
None yet
Milestone
Outdated
Development

No branches or pull requests
4 participants
@ilblackdragon @lexfrl @mikhailOK @MaksymZavershynskyi