Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add erc20/amount charge for meta transaction #3439

Open
ilblackdragon opened this issue Oct 2, 2020 · 1 comment
Open

Add erc20/amount charge for meta transaction #3439

ilblackdragon opened this issue Oct 2, 2020 · 1 comment
Assignees
Labels
A-EVM Area: Native EVM implementation and support A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-Aurora Team: issues relevant to the Aurora team

Comments

@ilblackdragon
Copy link
Member

ilblackdragon commented Oct 2, 2020

Linked to meta-tx tracking issue: #3338
There is spec described here: near/NEPs#106 (comment)

We should add an extra (address fee_token_address and unit268 fee_amount) into the message and call charging for that
prior to calling the actual execution (because it will fail if the amount is not there, hence making transaction cheaper for the environment).

@ilblackdragon ilblackdragon added C-enhancement Category: An issue proposing an enhancement or a PR with one. A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) labels Oct 2, 2020
@ilblackdragon ilblackdragon changed the title Add erc20/amount charge for meta transaction [EVM] Add erc20/amount charge for meta transaction Oct 5, 2020
@alexauroradev alexauroradev added the A-EVM Area: Native EVM implementation and support label Dec 4, 2020
@alexauroradev alexauroradev changed the title [EVM] Add erc20/amount charge for meta transaction Add erc20/amount charge for meta transaction Dec 4, 2020
@artob artob assigned artob and unassigned ailisp Jan 14, 2021
@bowenwang1996 bowenwang1996 added the T-Aurora Team: issues relevant to the Aurora team label Jun 29, 2021
@stale
Copy link

stale bot commented Sep 27, 2021

This issue has been automatically marked as stale because it has not had recent activity in the last 2 months.
It will be closed in 7 days if no further activity occurs.
Thank you for your contributions.

@stale stale bot added the S-stale label Sep 27, 2021
@akhi3030 akhi3030 removed the S-stale label Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-EVM Area: Native EVM implementation and support A-transaction-runtime Area: transaction runtime (transaction and receipts processing, state transition, etc) C-enhancement Category: An issue proposing an enhancement or a PR with one. T-Aurora Team: issues relevant to the Aurora team
Projects
None yet
Development

No branches or pull requests

6 participants