Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve validation for Contract Interact form #119

Open
marcinbodnar opened this issue Oct 24, 2022 · 2 comments
Open

Improve validation for Contract Interact form #119

marcinbodnar opened this issue Oct 24, 2022 · 2 comments

Comments

@marcinbodnar
Copy link
Contributor

marcinbodnar commented Oct 24, 2022

For some functions, the validation is missing.

For example:

  • in some cases, we don't check if form input is filled (for example the owner_id in new_default_meta)
  • we can check if the account_id has proper characters
  • we can consider checking if the account_id exists
  • we can check type_schema for some fields

The problem is that in some cases the user is informed about basic mistakes in the request error or in some cases in the Wallet while confirming tx. It is possible to minimize such situations.

@marcinbodnar marcinbodnar self-assigned this Oct 24, 2022
@shelegdmitriy
Copy link
Contributor

shelegdmitriy commented Oct 25, 2022

@marcinbodnar agree. There is related task to this https://github.com/near/developer-console-framework/issues/394

@marcinbodnar
Copy link
Contributor Author

Thanks @shelegdmitriy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants