Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Challenge 8 - Withdraw Rewards #58

Closed
joesixpack opened this issue Jul 29, 2022 · 8 comments
Closed

Challenge 8 - Withdraw Rewards #58

joesixpack opened this issue Jul 29, 2022 · 8 comments

Comments

@joesixpack
Copy link
Contributor

joesixpack commented Jul 29, 2022

Appears to be a bug with this contract call. Instead of just distributing the rewards (and it appears to have missed the second wallet also), it seems to unstake the entire validator stake and the validator disappears. Had to restake with fresh tokens above the minimum balance and ping to get it back into proposals.

challenge8

https://explorer.shardnet.near.org/transactions/Ge6baSvv7JrLmZERqRjec65ybYSUxmrXSzuxMVbt3nsY

@joesixpack
Copy link
Contributor Author

joesixpack commented Jul 31, 2022

I was stupid and tried it again, clearly it should not be unstaking the pool?

image

https://explorer.shardnet.near.org/transactions/HFiFh9fKiTDUy9WSchykqBxsczuSJMbEdBEZ6ed4yL7S#FtBdeLH5arWbhDG2Hjgnw8cjrPZzyX6PDLMK9MrB8d1u

@joetan79
Copy link

joetan79 commented Aug 1, 2022

I also having the same problem. After run this contract and it's withdraw all my staking as well as validators has been kicked out

@joesixpack
Copy link
Contributor Author

@Foo115
Copy link

Foo115 commented Aug 3, 2022

Im having same issue, i think there is some bug on the contract.
Had change the numerator and denomirator also to low as possible but still gettin unstaking all balance on pool

@ivanguardia
Copy link

I had the same. I lost 4 epochs -> unstake all, get rewards, stake all, ping, and finally set active again.
The withdrawal should be only the reward and not all the staking available.
This is a smartcontract issue.

@stiavnik
Copy link
Contributor

stiavnik commented Aug 9, 2022

Yes, as part of the challenge I submitted where exactly the error in code is, on the other side I may be wrong because I don't really know Rust yet. Remember the challenge asks as to report if something goes wrong, so...?

@onsails
Copy link

onsails commented Aug 21, 2022

Apparently I have the same issue with validator which was in active set and with brand new validator #114

@ShaMate256
Copy link

The same for me It unstaked all.

Use near call pool_id stake_all --accountId account to return stake back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants