Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add generic types to create functions #225

Closed
avin-kavish opened this issue Apr 15, 2022 · 7 comments · Fixed by #529
Closed

Add generic types to create functions #225

avin-kavish opened this issue Apr 15, 2022 · 7 comments · Fixed by #529

Comments

@avin-kavish
Copy link

I think it would be good to have these functions generically typed. If we know the shape of the payload, we can pass it here and get better type completion.

createSigner
createVerifier  

Would you accept a PR for this?

@avin-kavish avin-kavish changed the title Add generic types Add generic types to create functions Apr 15, 2022
@simoneb
Copy link
Member

simoneb commented Apr 15, 2022

Absolutely! Please remember to include tests for the types in https://github.com/nearform/fast-jwt/blob/master/test/types.spec.ts

@simoneb
Copy link
Member

simoneb commented Aug 19, 2022

@avin-kavish any update on this?

@avin-kavish
Copy link
Author

yeah, I did some work few months back. It's in #258

I don't think it's complete though.

@simoneb
Copy link
Member

simoneb commented Aug 19, 2022

Thanks. Are you planning to complete it?

@avin-kavish
Copy link
Author

yeah, at some point.

@simoneb
Copy link
Member

simoneb commented Dec 10, 2024

Closing due to lack of activity

@simoneb simoneb closed this as not planned Won't fix, can't repro, duplicate, stale Dec 10, 2024
Copy link
Contributor

🎉 This issue has been resolved in version 5.0.5 🎉

The release is available on:

Your optic bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants