Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RenovateBot] - Ensure ArgoCD Chart + .tool-version CLI is bumped in parallel by the same PR #24

Open
julianxhokaxhiu opened this issue Jan 17, 2023 · 1 comment
Assignees
Labels
enhancement New feature or request on-hold No work is required for now. Might be picked up in the future, or not.

Comments

@julianxhokaxhiu
Copy link
Member

julianxhokaxhiu commented Jan 17, 2023

Issue Type

Enhancement

Description

The Context:
In its current state, this project uses the Renovate Bot app to bump dependencies and update them automatically without human intervention. Although this is useful for long-term maintenance, there are some tweaks required to ensure the ArgoCD dependency is bumped correctly.

The Solution:
We need a special configuration that handles BOTH these cases and ensures they come up under one single PR somehow:

The main challenge here is to ensure two different managers cooperate ( asdf for .tool-versions and helmv3 for Charts ) accordingly to ensure they both produce a commit under a single PR. It is totally fine to have two different commits under the same PR as we anyway use the Squash and merge strategy.

@julianxhokaxhiu julianxhokaxhiu added the enhancement New feature or request label Jan 17, 2023
@julianxhokaxhiu julianxhokaxhiu self-assigned this Jan 18, 2023
@julianxhokaxhiu
Copy link
Member Author

Since the last week, I managed to accomplish the following things:

After all the discussion unfortunately it seems the renovate bot doesn't support this scenario and the team is not really interested in adding this feature ( for now ).

Therefore, after an internal alignment, there were some ideas that were brought to the table. The main idea is to trigger an action workflow that would trigger when either the .tool-versions or the argocd Chart has been changed, but different scenarios could be triggered:

  • ( more feasible ) Cross-check that they are both pointing to the same argocd version. If not, fail the CI job, if yes, mark it as successful OR;
  • (less feasible) When one of the two is updated, bump the other one

As this is not a high priority per se, we will put it on hold and wait until this issue really happens. If it will, we could pick it up and implement the aforementioned actions.

@julianxhokaxhiu julianxhokaxhiu added the on-hold No work is required for now. Might be picked up in the future, or not. label Jan 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request on-hold No work is required for now. Might be picked up in the future, or not.
Projects
None yet
Development

No branches or pull requests

1 participant