Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix bug where check_immutable_fields throws error with old version of Nebari #2796

Merged
merged 3 commits into from
Oct 25, 2024
Merged

fix bug where check_immutable_fields throws error with old version of Nebari #2796

merged 3 commits into from
Oct 25, 2024
+20 −12

Conversation

Adam-D-Lewis
Copy link
Member

Reference Issues or PRs

Fixes #2781

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

@Adam-D-Lewis Adam-D-Lewis changed the title fix issue 2781 with immutable fields check fix bug where check_immutable_fields throws error with old version of Nebari Oct 24, 2024
marcelovilla
marcelovilla approved these changes Oct 24, 2024
View reviewed changes
Copy link
Member

@marcelovilla marcelovilla left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Adam-D-Lewis ! I just tested this on a deployment I was trying to upgrade and it worked.

@Adam-D-Lewis Adam-D-Lewis merged commit ba0ae82 into main Oct 25, 2024
28 checks passed
@Adam-D-Lewis Adam-D-Lewis deleted the issue_2781 branch October 25, 2024 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marcelovilla marcelovilla marcelovilla approved these changes

@viniciusdc viniciusdc Awaiting requested review from viniciusdc

Assignees
No one assigned
Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - check_immutable_fields leads to a version mismatch error when performing an upgrade
2 participants
@Adam-D-Lewis @marcelovilla