Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Pytest Tests failing on PRs updating src #2790

Merged
merged 2 commits into from
Oct 23, 2024
Merged

Fix Pytest Tests failing on PRs updating src #2790

merged 2 commits into from
Oct 23, 2024

Conversation

joneszc
Copy link
Contributor

@joneszc joneszc commented Oct 23, 2024

Reference Issues or PRs

Fixes #2783

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

How to test this PR?

Any other comments?

image

@joneszc joneszc self-assigned this Oct 23, 2024
@viniciusdc
Copy link
Contributor

Thanks for the PR @joneszc!! These changes shouldn't have been merged at all (my bad).

@joneszc joneszc merged commit 42e0b15 into nebari-dev:main Oct 23, 2024
10 checks passed
@viniciusdc viniciusdc modified the milestone: 2024.9.2 Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@viniciusdc viniciusdc viniciusdc approved these changes

Assignees

@joneszc joneszc

Labels
None yet
Projects
🪴 Nebari Project Management
Status: Done 💪🏾
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[BUG] - PR pytests are failing, possibly because repo env vars are not available
2 participants
@joneszc @viniciusdc