Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is there a reason not to get the user's config by default if it exists? #139

Open
naupaka opened this issue Dec 19, 2022 · 4 comments
Open
Labels

Comments

@naupaka
Copy link

naupaka commented Dec 19, 2022

;; (conda--get-config)

Thanks for the great work on this. I am wondering why this is commented out by default. I've run into a tricky issue where org-roam requires ripgrep with pcre2 support, which isn't in the conda version of ripgrep, but it is in the homebrew version or the compiled version via cargo. So, the easy solution is to stop conda from activating the base environment by default, and then just activate a specific environment for use when working on a coding project. The way to do this is with conda config --set auto_activate_base false, which gets stored to the .condarc file.

So all is good now in a terminal, but not in GUI emacs or eshell in GUI emacs.

After some digging around, I found you have a function to read the condarc, but it's not run by default, those it seems like it probably should be?

In any event -- this isn't really a bug, but I'm wondering if there is a downside to getting the user's conda config? E.g. what might I unexpectedly break by doing this?

I've fixed my issue by adding the following to my config.org (using doom emacs with the +conda option to python).

(after! conda
  (conda--get-config))
@necaris
Copy link
Owner

necaris commented Dec 24, 2022

@naupaka doing things the way you have -- in (after! in Doom -- should be just fine! In fact, that's the way I have it set up myself!

The reason that (conda--get-config) is commented out is that I was concerned caching the configuration at load time might mess things up, if there are environment variables or other things that need to be set first.

@naupaka
Copy link
Author

naupaka commented Dec 24, 2022

Thanks for letting me know! You can close this issue -- I thought adding it would help other folks find it if they are running to the same problem even if it's not a bug.

@naupaka
Copy link
Author

naupaka commented Dec 24, 2022

Perhaps a small note in the readme might help people see that this is an option.

@necaris
Copy link
Owner

necaris commented Dec 24, 2022 via email

@necaris necaris added the config label May 15, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants