Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework how LEDs are set throughout out driver #351

Open
Kanuan opened this issue Apr 21, 2024 · 1 comment
Open

Rework how LEDs are set throughout out driver #351

Kanuan opened this issue Apr 21, 2024 · 1 comment
Labels
Core Core/Common Driver Topic enhancement New feature or request LED related Regarding controller player LEDs
Milestone

Comments

@Kanuan
Copy link
Collaborator

Kanuan commented Apr 21, 2024

LEDs are set in many different parts of the driver, and in each of them they do their logic on if they should or not set the LEDs based on the current LED authority.

This need to be reworked so simplify the code and to better manage LED states

@nefarius nefarius added enhancement New feature or request Core Core/Common Driver Topic labels Apr 22, 2024
@nefarius nefarius added this to the Version 3 milestone May 24, 2024
@nefarius nefarius added the LED related Regarding controller player LEDs label May 30, 2024
@Kanuan
Copy link
Collaborator Author

Kanuan commented Jun 2, 2024

To better mimic the PS3:

  • The 5 bytes related to a given LED effect should be all zeroes if the related LED flag is not set
  • For static LEDs, PS3 uses the following effect FF.00.01.00.01
    • This is: FF: Effect lasts infinitely; 00.01: portion duration equal to "1"; 00: No off portion; 01: On Portion Multiplier = 1;
    • We already know this is necessary for the LEDs in some replicas to behave correctly, see: Default output report LED effects are incorrect #365

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Core Core/Common Driver Topic enhancement New feature or request LED related Regarding controller player LEDs
Projects
None yet
Development

No branches or pull requests

2 participants